Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add securitycontext #17

Merged
merged 5 commits into from
Dec 7, 2023
Merged

add securitycontext #17

merged 5 commits into from
Dec 7, 2023

Conversation

andrewh1978
Copy link
Owner

No description provided.

@andrewh1978 andrewh1978 requested a review from bplein December 4, 2023 14:26
@bplein
Copy link
Collaborator

bplein commented Dec 6, 2023

Tested on Vanilla, got the following error:

  Type     Reason     Age               From               Message
  ----     ------     ----              ----               -------
  Normal   Scheduled  56s               default-scheduler  Successfully assigned chewram/chewram-c229j to node-1-1
  Normal   Pulled     1s (x6 over 55s)  kubelet            Container image "andrewh1978/px-bench" already present on machine
  Warning  Failed     1s (x6 over 55s)  kubelet            Error: container has runAsNonRoot and image will run as root (pod: "chewram-c229j_chewram(c710d424-d4cf-4ff9-854d-ec802da7be8c)", container: chewram)```

andrewh1978 and others added 3 commits December 6, 2023 16:51
@bplein
Copy link
Collaborator

bplein commented Dec 6, 2023

@andrewh1978 I removed the RunAsNonRoot and it works in vanilla. Can you retest chewram.yml in OCP?

I might also covert this to run in px-bench namespace, we don't need to litter in 2 of them.

change namespace to px-bench
@andrewh1978 andrewh1978 merged commit 0a0fb30 into main Dec 7, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants