Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add nodeSelector #22

Merged
merged 1 commit into from
Feb 8, 2024
Merged

add nodeSelector #22

merged 1 commit into from
Feb 8, 2024

Conversation

andrewh1978
Copy link
Owner

fixes #13

@andrewh1978 andrewh1978 requested a review from bplein January 10, 2024 15:30
bplein
bplein approved these changes Jan 10, 2024
View reviewed changes
Copy link
Collaborator

@bplein bplein left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with Vanilla deployment via px-deploy on K8s v1.27.6, tested with a valid hostname and with an invalid hostname, and it deployed correctly in the valid hostname case, and stayed in Pending state with the invalid hostname, as expected.

@andrewh1978 andrewh1978 merged commit 54f30a7 into main Feb 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bplein bplein bplein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: Pin benchmark to run on certain node(s)
2 participants
@andrewh1978 @bplein