Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split interceptors into a separate package #125

Merged
merged 4 commits into from
Jan 26, 2025
Merged

Conversation

andrewlock
Copy link
Owner

The interceptor support adds design-time overhead, due to the use of CreateSyntaxProvider that I can't find a good way to avoid. Rather than penalise the base package for an experimental and niche feature, move the interceptor to a separate package.

Copy link

Test Results

   143 files   -  11     143 suites   - 11   6m 58s ⏱️ - 1m 59s
 4 095 tests  -  29   4 091 ✅  - 13   4 💤  -  16  0 ❌ ±0 
67 376 runs   - 143  67 310 ✅ +11  66 💤  - 154  0 ❌ ±0 

Results for commit 71eae22. ± Comparison against base commit 651db1b.

This pull request removes 56 and adds 27 tests. Note that renamed tests count towards both.
NetEscapades.EnumGenerators.Interceptors.IntegrationTests.InterceptorTests ‑ CallingToStringIsNotInterceptedWhenNotSupportedBySdk
NetEscapades.EnumGenerators.NetStandard.Interceptors.IntegrationTests.InterceptorTests ‑ CallingToStringIsNotInterceptedWhenNotSupportedBySdk
NetEscapades.EnumGenerators.Nuget.Interceptors.IntegrationTests.InterceptorTests ‑ CallingToStringIsNotInterceptedWhenNotSupportedBySdk
NetEscapades.EnumGenerators.Nuget.Interceptors.IntegrationTests.Roslyn4_4.InterceptorTests ‑ CallingHasFlagIsIntercepted
NetEscapades.EnumGenerators.Nuget.Interceptors.IntegrationTests.Roslyn4_4.InterceptorTests ‑ CallingHasFlagIsIntercepted_ExternalEnumFlags
NetEscapades.EnumGenerators.Nuget.Interceptors.IntegrationTests.Roslyn4_4.InterceptorTests ‑ CallingNonInterceptableEnumIsNotIntercepted
NetEscapades.EnumGenerators.Nuget.Interceptors.IntegrationTests.Roslyn4_4.InterceptorTests ‑ CallingToStringIsIntercepted
NetEscapades.EnumGenerators.Nuget.Interceptors.IntegrationTests.Roslyn4_4.InterceptorTests ‑ CallingToStringIsIntercepted_EnumInFoo
NetEscapades.EnumGenerators.Nuget.Interceptors.IntegrationTests.Roslyn4_4.InterceptorTests ‑ CallingToStringIsIntercepted_EnumWithExtensionInOtherNamespace
NetEscapades.EnumGenerators.Nuget.Interceptors.IntegrationTests.Roslyn4_4.InterceptorTests ‑ CallingToStringIsIntercepted_ExternalEnum
…
NetEscapades.EnumGenerators.Tests.EnumGeneratorInterceptorTests ‑ CanGenerateEnumExtensionsForFlagsEnum(usings: "", attribute: "System.Flags")
NetEscapades.EnumGenerators.Tests.EnumGeneratorInterceptorTests ‑ CanGenerateEnumExtensionsForFlagsEnum(usings: "", attribute: "System.FlagsAttribute")
NetEscapades.EnumGenerators.Tests.EnumGeneratorInterceptorTests ‑ CanGenerateEnumExtensionsForFlagsEnum(usings: "using System;", attribute: "Flags")
NetEscapades.EnumGenerators.Tests.EnumGeneratorInterceptorTests ‑ CanGenerateEnumExtensionsForFlagsEnum(usings: "using System;", attribute: "FlagsAttribute")
NetEscapades.EnumGenerators.Tests.EnumGeneratorInterceptorTests ‑ CanGenerateEnumExtensionsInChildNamespace
NetEscapades.EnumGenerators.Tests.EnumGeneratorInterceptorTests ‑ CanGenerateEnumExtensionsInGlobalNamespace
NetEscapades.EnumGenerators.Tests.EnumGeneratorInterceptorTests ‑ CanGenerateEnumExtensionsInNestedClass
NetEscapades.EnumGenerators.Tests.EnumGeneratorInterceptorTests ‑ CanGenerateEnumExtensionsWithCustomName
NetEscapades.EnumGenerators.Tests.EnumGeneratorInterceptorTests ‑ CanGenerateEnumExtensionsWithCustomNamespace
NetEscapades.EnumGenerators.Tests.EnumGeneratorInterceptorTests ‑ CanGenerateEnumExtensionsWithCustomNamespaceAndName
…

@andrewlock andrewlock merged commit 62805d4 into main Jan 26, 2025
5 checks passed
@andrewlock andrewlock deleted the split-interceptors branch January 26, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant