This repository has been archived by the owner on May 26, 2022. It is now read-only.
Update Documentation and Sample App to make fetching Multiple IPv6 Address More Clear #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iple IP addresses
…port for multi address display
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply clarifies some of the documentation and the sample app to make it more clear which API method to use when trying to fetch multiple IPv6 addresses. There is no change in functionality to the library itself.
The update to the sample app makes it so that all IP addresses are shown on screen instead of just one.
Thanks for creating and maintaining this library @andriydruk -- for some reason Google's
NsdManagerisn't capable of reporting IPv6 addresses (which is a huge bummer), so this library is a big win for the community!