Revert "refactor: use Closeable#use extension where applicable"

This reverts commit 69513bf.
android-password-store · Sep 26, 2024 · 04f4b98 · 04f4b98
1 parent cb22561
commit 04f4b98
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/app/src/main/java/app/passwordstore/util/services/PasswordExportService.kt b/app/src/main/java/app/passwordstore/util/services/PasswordExportService.kt
@@ -89,7 +89,10 @@ class PasswordExportService : Service() {
       val destOutputStream = contentResolver.openOutputStream(targetPasswordFile.uri)
 
       if (destOutputStream != null && sourceInputStream != null) {
-        sourceInputStream.use { source -> destOutputStream.use { dest -> source.copyTo(dest) } }
+        sourceInputStream.copyTo(destOutputStream, 1024)
+
+        sourceInputStream.close()
+        destOutputStream.close()
       }
     }
   }

diff --git a/crypto/pgpainless/src/main/kotlin/app/passwordstore/crypto/PGPainlessCryptoHandler.kt b/crypto/pgpainless/src/main/kotlin/app/passwordstore/crypto/PGPainlessCryptoHandler.kt
@@ -65,7 +65,8 @@ public class PGPainlessCryptoHandler @Inject constructor() :
                 .addDecryptionKeys(keyringCollection, protector)
                 .addDecryptionPassphrase(Passphrase.fromPassword(passphrase))
             )
-        decryptionStream.use { Streams.pipeAll(it, outputStream) }
+        Streams.pipeAll(decryptionStream, outputStream)
+        decryptionStream.close()
         return@runCatching
       }
       .mapError { error ->
@@ -120,7 +121,8 @@ public class PGPainlessCryptoHandler @Inject constructor() :
             .setAsciiArmor(options.isOptionEnabled(PGPEncryptOptions.ASCII_ARMOR))
         val encryptionStream =
           PGPainless.encryptAndOrSign().onOutputStream(outputStream).withOptions(producerOptions)
-        encryptionStream.use { Streams.pipeAll(plaintextStream, it) }
+        Streams.pipeAll(plaintextStream, encryptionStream)
+        encryptionStream.close()
         val result = encryptionStream.result
         publicKeyRingCollection.forEach { keyRing ->
           require(result.isEncryptedFor(keyRing)) {