Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rainbowhat - Update README.md #126

Merged
merged 2 commits into from
Aug 15, 2019

Conversation

adkl
Copy link
Contributor

@adkl adkl commented Aug 7, 2019

  • Register Bmx280 temperature sensor before registering dynamic sensor callback

Based on my experience and also a discussion from #103, maybe it should be useful to state this important block of code in the docs.

- Register Bmx280 temperature sensor before registering dynamic sensor callback
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@adkl
Copy link
Contributor Author

adkl commented Aug 7, 2019

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@devunwired devunwired self-assigned this Aug 8, 2019
@devunwired devunwired self-requested a review August 8, 2019 16:24
Copy link
Contributor

@devunwired devunwired left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing this.
We need to separate the blocks of code a bit more, as these two things are not necessarily expected to happen in the same scope (see the example above it for input drivers). There should be a separate block for the code you added with a comment about registering the listener in your activity.

@adkl
Copy link
Contributor Author

adkl commented Aug 15, 2019

I agree, now it looks more convenient.

@devunwired devunwired merged commit 331beda into androidthings:master Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants