flash-tools: add back missing lz4c program #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since lz4/lz4@65998fe, the lz4c symlink no longer exists, but is wanted by `flash.sh`. The `lz4` program adds a set of legacy cmdline flags when `argv[0]` is `lz4c` (see https://github.com/lz4/lz4/blob/6cf42afbea04c9ea6a704523aead273715001330/programs/lz4cli.c#L444), however NVIDIA doesn't use any of these legacy flags in `flash.sh`, they only require the `lz4c` program to be in PATH.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Since lz4/lz4@65998fe,
the lz4c symlink no longer exists, but is wanted by
flash.sh. Thelz4program adds a set of legacy cmdline flags whenargv[0]islz4c(see https://github.com/lz4/lz4/blob/6cf42afbea04c9ea6a704523aead273715001330/programs/lz4cli.c#L444),however NVIDIA doesn't use any of these legacy flags in
flash.sh, theyonly require the
lz4cprogram to be in PATH.Testing
Building the
bupderivation for an orin-agx-devkit no longer fails using a nixpkgs rev from the nixos-24.11 release.