🤖 Merge PR DefinitelyTyped#68539 [react-data-grid] Remove usage of de…

…precated string refs in tests by @eps1lon
andyGallagher · Feb 8, 2024 · 52aee1d · 52aee1d
1 parent 54d2875
commit 52aee1d
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 6 deletions.
diff --git a/types/react-data-grid/react-data-grid-tests.tsx b/types/react-data-grid/react-data-grid-tests.tsx
@@ -244,6 +244,7 @@ var columns: Array<ReactDataGrid.Column<typeof counties>> = [
 ];
 
 class Example extends React.Component<any, any> {
+    gridRef = React.createRef<ReactDataGrid<Array<{ id: number; title: string }>>>();
     getInitialState() {
         var fakeRows = createRows(2000);
         return { rows: fakeRows };
@@ -255,7 +256,7 @@ class Example extends React.Component<any, any> {
             onClick: (ev: React.SyntheticEvent<any>, args: { idx: number; rowIdx: number }) => {
                 var idx = args.idx;
                 var rowIdx = args.rowIdx;
-                (this.refs.grid as ReactDataGrid<{}>).openCellEditor(rowIdx, idx);
+                (this.gridRef.current!).openCellEditor(rowIdx, idx);
             },
         };
 
@@ -330,7 +331,7 @@ class Example extends React.Component<any, any> {
         let selectedRows = ["id1", "id2"];
         return (
             <ReactDataGrid
-                ref="grid"
+                ref={this.gridRef}
                 enableCellSelect={true}
                 enableDragAndDrop={true}
                 columns={this.getColumns()}

diff --git a/types/react-data-grid/v1/react-data-grid-tests.tsx b/types/react-data-grid/v1/react-data-grid-tests.tsx
@@ -190,6 +190,7 @@ var columns: ReactDataGrid.Column[] = [
 ];
 
 class Example extends React.Component<any, any> {
+    gridRef = React.createRef<ReactDataGrid>();
     getInitialState() {
         var fakeRows = createRows(2000);
         return { rows: fakeRows };
@@ -201,7 +202,7 @@ class Example extends React.Component<any, any> {
             onClick: (ev: React.SyntheticEvent<any>, args: { idx: number; rowIdx: number }) => {
                 var idx = args.idx;
                 var rowIdx = args.rowIdx;
-                this.refs.grid as ReactDataGrid;
+                this.gridRef!;
             },
         };
 
@@ -258,7 +259,7 @@ class Example extends React.Component<any, any> {
         let selectedRows = ["id1", "id2"];
         return (
             <ReactDataGrid
-                ref="grid"
+                ref={this.gridRef}
                 enableCellSelect={true}
                 columns={this.getColumns()}
                 rowGetter={this.getRowAt}

diff --git a/types/react-data-grid/v2/react-data-grid-tests.tsx b/types/react-data-grid/v2/react-data-grid-tests.tsx
@@ -244,6 +244,7 @@ var columns: ReactDataGrid.Column[] = [
 ];
 
 class Example extends React.Component<any, any> {
+    gridRef = React.createRef<ReactDataGrid>();
     getInitialState() {
         var fakeRows = createRows(2000);
         return { rows: fakeRows };
@@ -255,7 +256,7 @@ class Example extends React.Component<any, any> {
             onClick: (ev: React.SyntheticEvent<any>, args: { idx: number; rowIdx: number }) => {
                 var idx = args.idx;
                 var rowIdx = args.rowIdx;
-                (this.refs.grid as ReactDataGrid).openCellEditor(rowIdx, idx);
+                this.gridRef.current.openCellEditor(rowIdx, idx);
             },
         };
 
@@ -333,7 +334,7 @@ class Example extends React.Component<any, any> {
         let selectedRows = ["id1", "id2"];
         return (
             <ReactDataGrid
-                ref="grid"
+                ref={this.gridRef}
                 enableCellSelect={true}
                 enableDragAndDrop={true}
                 columns={this.getColumns()}