add linter rule typescript/member-ordering

.eslintrc

@@ -6,6 +6,7 @@
     "no-console": "warn",
     "typescript/no-unused-vars": "error",
     "typescript/explicit-member-accessibility": "error",
+    "typescript/member-ordering": "error",
     "no-only-tests/no-only-tests": "error"
   }
 }

src/scraper/scrape-step/downloader/implementations/http.ts

@@ -31,11 +31,6 @@ type FetchFunction = (
 export class Downloader extends AbstractDownloader<DownloadData> {
   private urlTemplate: ReturnType<typeof compileTemplate>
   private headerTemplates: Map<string, ReturnType<typeof compileTemplate>>
-  private verifyResponseOk = (response: Fetch.Response, url: string) => {
-    if (!response.ok) {
-      throw new Error(`status ${response.status} for ${url}`)
-    }
-  }
   private fetcher: FetchFunction
 
   public constructor(config: ScrapeConfig, options: Options, tools: Tools) {
@@ -80,6 +75,11 @@ export class Downloader extends AbstractDownloader<DownloadData> {
     return this.fetcher(downloadId, downloadData)
   }
 
+  private verifyResponseOk = (response: Fetch.Response, url: string) => {
+    if (!response.ok) {
+      throw new Error(`status ${response.status} for ${url}`)
+    }
+  }
   private downloadToFileAndMemory: FetchFunction = async (
     downloadId,
     [url, fetchOptions]

src/scraper/scrape-step/index.ts

@@ -1,6 +1,5 @@
 import * as Rx from 'rxjs'
 import * as ops from 'rxjs/operators'
-import VError from 'verror'
 import { downloaderClassFactory } from './downloader'
 import { parserClassFactory } from './parser'
 import { incrementer } from './incrementer'
@@ -69,6 +68,22 @@ class ScrapeStep extends AbstractScrapeStep {
       scrapeNextChild
     )
   }
+
+  public run: typeof AbstractScrapeStep.prototype.run = (
+    parentValues: ParsedValue[]
+  ): Rx.Observable<ParsedValue[]> =>
+    Rx.from(parentValues).pipe(
+      ops.flatMap(this.incrementObservableFunction),
+      ops.catchError(wrapError(`scraper '${this.scraperName}'`)),
+      ops.flatMap(
+        parsedValues =>
+          this.children.length
+            ? this.children.map(child => child.run(parsedValues))
+            : [Rx.of(parsedValues)]
+      ),
+      ops.mergeAll()
+    )
+
   private downloadParseFunction: DownloadParseFunction = async (
     { parsedValue: value, id: parentId },
     incrementIndex
@@ -115,20 +130,6 @@ class ScrapeStep extends AbstractScrapeStep {
       return parsedValuesWithId
     }
   }
-  public run: typeof AbstractScrapeStep.prototype.run = (
-    parentValues: ParsedValue[]
-  ): Rx.Observable<ParsedValue[]> =>
-    Rx.from(parentValues).pipe(
-      ops.flatMap(this.incrementObservableFunction),
-      ops.catchError(wrapError(`scraper '${this.scraperName}'`)),
-      ops.flatMap(
-        parsedValues =>
-          this.children.length
-            ? this.children.map(child => child.run(parsedValues))
-            : [Rx.of(parsedValues)]
-      ),
-      ops.mergeAll()
-    )
 }
 
 export { ScrapeStep, IdentityScrapeStep }

src/scraper/scrape-step/parser/implementations/html.ts

@@ -8,6 +8,12 @@ import { Tools } from '../../../../tools'
 export class Parser extends AbstractParser {
   private parser: (value: string) => string[]
 
+  public constructor(config: ScrapeConfig, options: Options, tools: Tools) {
+    super(config, options, tools)
+    this.parser = this.attribute ? this.selectAttrVals : this.selectTextVals
+  }
+  protected parse = (value: string) => this.parser(value)
+
   private selectTextVals = (value: string) => {
     const $ = cheerio.load(value)
     const values: string[] = []
@@ -26,10 +32,4 @@ export class Parser extends AbstractParser {
     })
     return values
   }
-  protected parse = (value: string) => this.parser(value)
-
-  public constructor(config: ScrapeConfig, options: Options, tools: Tools) {
-    super(config, options, tools)
-    this.parser = this.attribute ? this.selectAttrVals : this.selectTextVals
-  }
 }