Set internal attrs directly in Plane constructor (resolves #53)

lentil/plane.py

@@ -55,11 +55,13 @@ def __init__(self, amplitude=1, opd=0, mask=None, pixelscale=None, diameter=None
                                 "which are aliases of one another")
             amplitude = kwargs['amp']
 
-        self.amplitude = np.asarray(amplitude)
-        self.opd = np.asarray(opd)
+        # directly set internal attributes rather relying on property setter
+        # see: https://github.com/andykee/lentil/issues/53
+        self._amplitude = np.asarray(amplitude)
+        self._opd = np.asarray(opd)
 
         if mask is None:
-            mask = np.copy(self.amplitude)
+            mask = np.copy(self._amplitude)
 
         mask[mask != 0] = 1
         self._mask = mask

tests/test_plane.py

@@ -36,6 +36,34 @@ def test_amp_alias_error():
     with pytest.raises(TypeError):
         lentil.Plane(amplitude=10, amp=10)
 
+
+class PlaneAttributeOverload(lentil.Plane):
+    def __init__(self):
+        super().__init__()
+
+    @property
+    def amplitude(self):
+        return np.array(1)
+
+    @property
+    def opd(self):
+        return np.array(2)
+
+
+def test_plane_overload_propertyes():
+    p = PlaneAttributeOverload()
+
+    assert p.amplitude == 1
+    assert p.opd == 2
+    assert p.mask == 1
+
+    with pytest.raises(AttributeError):
+        p.opd = 5
+
+    with pytest.raises(AttributeError):
+        p.amplitude = 5
+
+
 def test_plane_fit_tilt_inplace():
     p = RandomPlane()
     p_copy = p.fit_tilt(inplace=False)