Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: MoveOperation path comparisons #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shellbj
Copy link

@shellbj shellbj commented Nov 7, 2024

This commit fixes a defect in the MoveOperation's path comparisons for trees belonging to the same root. Comparisons are now done on each path element, individually, with the destination's elements; properly determining if it's a subtree or not.

This is now a valid patch:

[
     { "op": "move", "from": "/a/b/c", "path": "/a/b/cdefg" }
]

This commit fixes a defect in the MoveOperation's path comparisons for trees belonging to the same root. Comparisons are now done on each path element, individually, with the destination's elements; properly determining if it's a subtree or not.

This is now a valid patch:
```
[
     { "op": "move", "from": "/a/b/c", "path": "/a/b/cdefg" }
]
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant