Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve fruit press #100

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Improve fruit press #100

wants to merge 3 commits into from

Conversation

glutzer
Copy link

@glutzer glutzer commented Jan 25, 2025

Can now add fractional amounts of wet mash.
Fixed bug where it randomly stops working until you break it.
Animations are client only now.
Removed global key listener.
Now prevents actions until fully unscrewed.

@pizza2004
Copy link

pizza2004 commented Jan 25, 2025

Luckily the bug where it randomly stops working is already fixed and will be included in the next version, so we don't need to wait on reviewing this for that to be fixed.

Can you comment on why you removed the stuff like proportional speed for juicing, extra juice dripping out when the screw is released, and juiceableLitresTransfered being added to the machine when inserting a mash? I know in the case of the last it will cause players to lose dry mash if they add a partial mash, if not programmed correctly, plus you missed updating the variable you pass to the audit so it would just say "0x" there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants