Add implementation of package linting rule and tests #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosliarte
force-pushed
the
feature/package_lint_rule
branch
from
a2a6cb9 to
7baf84d
Compare
|
Solves #29 |
alexvanboxel
reviewed
Apr 4, 2019
| Descriptors.FileDescriptor fileDescriptor = proto.getFileDescriptorByFileName(ref.getFile().getName()); | ||
| String protoPackageName = fileDescriptor.getPackage(); | ||
| String fileName = ref.getFile().getFullName(); | ||
| fileName = fileName.substring(0, fileName.lastIndexOf("/")).replace("/", "."); |
There was a problem hiding this comment.
The result of the substring is a directory name. Use a new variable dirName to indicate what it is.
alexvanboxel
reviewed
Apr 4, 2019
| String protoPackageName = fileDescriptor.getPackage(); | ||
| String fileName = ref.getFile().getFullName(); | ||
| fileName = fileName.substring(0, fileName.lastIndexOf("/")).replace("/", "."); | ||
| if(!fileName.equals(protoPackageName)){ |
There was a problem hiding this comment.
Use your IntelliJ code formatter to make sure your code is correctly formatted. Add space before opening bracket.
alexvanboxel
reviewed
Apr 4, 2019
| @@ -27,4 +27,7 @@ enum LintRule { | |||
| LINT_METHOD_RTYPE_END_WITH_RESPONSE = 50003; | |||
|
|
|||
| LINT_GENERAL_CUSTOM = 60000; | |||
|
|
|||
| LINT_PACKAGE_CUSTOM = 70000; | |||
| LINT_PACKAGE_NAME_SHOULD_BE_VALID = 70001; | |||
There was a problem hiding this comment.
change to LINT_PACKAGE_NO_DIR_ALIGNMENT
carlosliarte
force-pushed
the
feature/package_lint_rule
branch
from
7baf84d to
02edb47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.