Bump Tapioca to 0.16.9, and gem version to 0.0.17 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stathis-alexander wondering if you could take a look? Thanks! |
There was a problem hiding this comment.
Hi @franklinhu , thanks for contributing. Sorry to have missed your pull request!
|
Let me quickly review the Tapioca changes and see if anything needs changing. I don't think there should be. I specifically skipped 0.16.8 because they introduce a bug. |
|
@franklinhu - I've merged this and added a new release to gemfury. Let me know if you encounter any issues. |
|
Great thanks for the quick turn around! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I wanted to test out this gem, but we're using a newer version of Tapioca in our repo.
Changes
~>from<=. Not sure if you intended<=but seemed odd to require only older versions and not newer ones.~>strikes a nice balance since it'll match all patch versions so you should need to bump it less frequentlyLet me know if there's anything else I can fix up!