fix(pagespeed): update fqdn + instructions #180
Conversation
|
should fix the failing build on debian 9, just fixed the script, (was my error). https://github.com/angristan/nginx-autoinstall/pull/180/checks?check_run_id=2149567703#step:3:9015 ./configure: error: invalid option "To"Additionally while examining the logs, these two issues cropped up: apt-utils dependency: debconf: delaying package configuration, since apt-utils is not installedsystemctl error: https://github.com/angristan/nginx-autoinstall/pull/180/checks?check_run_id=2149567703#step:3:9018 ../../nginx-autoinstall.sh: line 597: systemctl: command not found |
nginx-autoinstall.sh
Outdated
| wget https://github.com/apache/incubator-pagespeed-ngx/archive/v1.14.33.1-RC1.zip | ||
| unzip v1.14.33.1-RC1.zip | ||
| cd incubator-pagespeed-ngx-1.14.33.1-RC1 || exit 1 | ||
| psol_url=https://dist.apache.org/repos/dist/release/incubator/pagespeed/1.14.36.1/x64/psol-1.14.36.1-apache-incubating-x64.tar.gz |
There was a problem hiding this comment.
Please use NPS_VER instead of hardcoding the version and use the same version (v1.14.33.1-RC1 vs 1.14.36.1)
There was a problem hiding this comment.
would NPS_VER=1.14.33.1-RC1 work for you? There are no other versions for 1.18.0+ nginx, everything else is >2018 or older.
1.14.36.1 is the Apache2 client, this version is the only recent official release
nginx-autoinstall.sh
Outdated
| apt-get install -y build-essential ca-certificates wget curl libpcre3 libpcre3-dev autoconf unzip automake libtool tar git libssl-dev zlib1g-dev uuid-dev lsb-release libxml2-dev libxslt1-dev cmake | ||
|
|
||
| apt-get install -qy apt-utils m4 build-essential ca-certificates wget curl libpcre3 libpcre3-dev autoconf unzip automake libtool tar git libssl-dev zlib1g-dev uuid-dev lsb-release libxml2-dev libxslt1-dev cmake | ||
| apt-get update | ||
|
|
There was a problem hiding this comment.
Please revert these changes and only add the new dependencies at the end
|
Hello, the patch doesn't work: |
Targeting the build for Will go ahead and make the requested adjustments, thank you. |
this fixes the deadlinks for pagespeed, see [https://github.com/apache/incubator-pagespeed-ngx/issues/1656](https://github.com/apache/incubator-pagespeed-ngx/issues/1656). Also added clearer instructions if pagespeed is used as a module so that users know to adjust their `nginx.conf`
this fixes the deadlinks for pagespeed, see apache/incubator-pagespeed-ngx/issues/1656.
Also added clearer instructions if pagespeed is used as a module so that users know to adjust their
nginx.conf