Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Properly position "uib-dropdown-menu" when it has class "dropdown-menu-right" and the parent element have hidden scrollbar #6601

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Properly position "uib-dropdown-menu" when it has class "dropdown-menu-right" and the parent element have hidden scrollbar #6601

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
adc8373
scrollbarPadding() function checks also whether the scrollbars are vi…
Stalinko Jul 25, 2017
f20ef95
When positioning a dropdown aligned to the right properly check wheth…
Stalinko Jul 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/dropdown/dropdown.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ angular.module('ui.bootstrap.dropdown', ['ui.bootstrap.multiMap', 'ui.bootstrap.
css.left = 'auto';
scrollbarPadding = $position.scrollbarPadding(appendTo);

if (scrollbarPadding.heightOverflow && scrollbarPadding.scrollbarWidth) {
if (scrollbarPadding.rightScrollbar && scrollbarPadding.scrollbarWidth) {
scrollbarWidth = scrollbarPadding.scrollbarWidth;
}

Expand Down
6 changes: 5 additions & 1 deletion src/position/position.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,11 @@ angular.module('ui.bootstrap.position', [])
originalRight: paddingRight,
heightOverflow: scrollParent.scrollHeight > scrollParent.clientHeight,
bottom: paddingBottom + scrollbarWidth,
originalBottom: paddingBottom
originalBottom: paddingBottom,
bottomScrollbar: (elemStyle.overflowX == 'auto' || elemStyle.overflowX == 'visible' && elem.nodeName == 'BODY')
&& scrollParent.scrollWidth > scrollParent.clientWidth || elemStyle.overflowX == 'scroll',
rightScrollbar: (elemStyle.overflowY == 'auto' || elemStyle.overflowY == 'visible' && elem.nodeName == 'BODY')
&& scrollParent.scrollHeight > scrollParent.clientHeight || elemStyle.overflowY == 'scroll'
};
},

Expand Down