Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New algorithms is added #186

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

anishsingh935
Copy link

No description provided.

@aniketsharma00411
Copy link
Owner

Could you please update the README files as mentioned in the Contributor's Guide? Also, add the problem statement as comments for juggling.cpp

@anishsingh935
Copy link
Author

Could you please update the README files as mentioned in the Contributor's Guide? Also, add the problem statement as comments for juggling.cpp

sure

@anishsingh935
Copy link
Author

hi I had updated according to your suggestion
you can review and merge successfully
Thanks a lot for giving me chance

Copy link
Owner

@aniketsharma00411 aniketsharma00411 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two files ('juggling.cpp' and 'jungling.cpp') doing the same job.

Also, add pattern_find.cpp in the README too.

@anishsingh935
Copy link
Author

ok I am updating

@anishsingh935
Copy link
Author

Now all changes has been done as per your suggestion

@aniketsharma00411
Copy link
Owner

Now all changes has been done as per your suggestion

No. Not all changes are done.

As it is obvious this is not a very serious repo. So, I will give you an opportunity to find yourself what is missing. Feel free to ask me if you have any problems but you should be able to fix all the problems before asking to merge the PR. Read the Contributing Guidelines and what I asked to correct again.

@anishsingh935
Copy link
Author

ok Ok I got it I have to add juggling algorithm to readme.md as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants