Skip to content
This repository has been archived by the owner on Jan 26, 2021. It is now read-only.

Added Header footer #1085

Closed
wants to merge 6 commits into from
Closed

Added Header footer #1085

wants to merge 6 commits into from

Conversation

pallavithakare28
Copy link

@pallavithakare28 pallavithakare28 commented Sep 3, 2020

I am done with the setup and trying to make changes. Added header, footer and looking forward to making more attractive changes.

Description

Trying to add header and footer and working on the other aspects.

Fixes #1034

Type of Change: Wireframe design for Home page

  • Code
  • User Interface
    Final_wireframe

Code/Quality Assurance Only

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update (software upgrade on readme file)
  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

Describe the tests you ran to verify your changes. Provide instructions or GIFs so we can reproduce. List any relevant details for your test.

Checklist:

Delete irrelevant options.

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged

Code/Quality Assurance Only

  • My changes generate no new warnings
  • My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been published in downstream modules

I am done with the setup and trying to make changes. Added header, footer and looking forward to making more attractive changes.
@pallavithakare28
Copy link
Author

@Kajol-Kumari Hello mam, I have added the screenshots. Please let me know where I have to correct it. And guide me for further.

@Kajol-Kumari
Copy link

Hey @pallavithakare28 please do any coding stuff in this PR, you just need to make the wireframe design for this issue. And regarding the design, Current header looks much better than the one you have shared here. so if you can make the header design having UI better than the current version, it would be grate otherwise keep the current header only.

@pallavithakare28
Copy link
Author

@Kajol-Kumari I will try my level best to make it attractive. I will definitely do it soon. :)

@pallavithakare28
Copy link
Author

pallavithakare28 commented Sep 4, 2020

@Kajol-Kumari Hello mam, I have attached a wireframe design in the description. Is it correct? The issue is expecting for the same solution, please suggest me how to proceed further.

@Kajol-Kumari
Copy link

Hey @pallavithakare28 I am sorry if i was not clear to you but you just need to use tools like figma or balsamiq to make the UI/UX design for the home page, take it's screenshot and add it under wireframes folder(create this folder as we don't have it currently) and make the PR. We don't need any code or anything else for this issue. Just the design image is required. If you still need any clarifications, feel free to ask it.

@pallavithakare28
Copy link
Author

Hi @Kajol-Kumari, Please refer to my new PR since I have closed this one. Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI] Wireframe Design for homepage
2 participants