This repository has been archived by the owner on Jan 26, 2021. It is now read-only.
Updated views.py file for issue #889 #1087
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the data type for city in line 105 from "pk" to "name"
keshakaneria
approved these changes
Sep 4, 2020
|
Sorry...by mistakely the above happened😅 |
Thank you ! |
|
@sanchibansal340 Is it approved now ? If yes, then what should i do, close this or merge this ? 😅 |
|
@alivabasa All the PR's will be merged after the program ends |
@sanchibansal340 ok. So can i work on another one now? |
|
Yes you can |
|
Thanks !! |
keshakaneria
added
Status: Ready to Merge
sanchibansal340
added
Status: Needs Testing
devkapilbansal
suggested changes
Oct 15, 2020
There was a problem hiding this comment.
@alivabasa this commit should enforce issue closing too. Add fixes #issue_no in your commit message
|
@devkapilbansal Done! |
2 tasks
|
@alivabasa this error might have been solved already.Can you please update your branch with current develop head. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#889 Description
Changed the data type of city field in line 105 from "pk" to "name"
Fixes #889
Type of Change:
How Has This Been Tested?
It works in linux terminal.
Checklist: