Skip to content
This repository has been archived by the owner on Jan 26, 2021. It is now read-only.

Update home.html #1101

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

bhumikasharma29
Copy link

@bhumikasharma29 bhumikasharma29 commented Sep 9, 2020

Description

The word "Systers" was replaced with "Anita Borg" on the landing page.
Fixes #1049

Type of Change:

  • Documentation

Code/Quality Assurance Only

  • This change requires a documentation update (software upgrade on readme file)

Checklist:

  • My PR follows the style guidelines of this project
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged

Code/Quality Assurance Only

  • My changes generate no new warnings

Systers replaced by Anita Borg on the landing page
Fixes #1049
@sanchibansal340
Copy link

@bhumikasharma29 Can you please include the details added on the top below #Description?

@sanchibansal340
Copy link

@bhumikasharma29 I guess let it be Anita Borg Institute Community instead of Anita Borg, an Anita Borg Institute Community

@keshakaneria
Copy link
Member

@bhumikasharma29 It shows conflicts that must be resolved first. Once it is done we'll approve the changes. Change looks good to me.

@keshakaneria
Copy link
Member

@bhumikasharma29 have you resolved the conflicts? If yes, do commit the changes again so that we can proceed to finalize this PR :)

@bhumikasharma29
Copy link
Author

@keshakaneria I resolved the conflict. Please check.

@codecov
Copy link

codecov bot commented Sep 23, 2020

Codecov Report

Merging #1101 into develop will decrease coverage by 0.36%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1101      +/-   ##
===========================================
- Coverage    87.30%   86.93%   -0.37%     
===========================================
  Files           85       85              
  Lines         4057     4057              
  Branches       237      237              
===========================================
- Hits          3542     3527      -15     
- Misses         445      458      +13     
- Partials        70       72       +2     
Impacted Files Coverage Δ
vms/shift/views.py 61.40% <0.00%> (-2.21%) ⬇️
vms/event/views.py 77.63% <0.00%> (-1.69%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8a4ea7...32686d5. Read the comment docs.

<h1 class="index">Volunteer Management System</h1>
<p>{% trans "Systers, an Anita Borg Institute Community, has many volunteers that devote their time, skills and commitment to our vision. Volunteer Management System serves as a place where volunteers can view volunteer events, sign up for volunteer jobs and log volunteer hours. Volunteer Management System also enables volunteer managers to manage their volunteers and run volunteer related reports." %}
</p>
{% if user.is_authenticated %}
Copy link
Member

@keshakaneria keshakaneria Sep 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I know why was this removed? The issue says just to edit the test so I suppose this button is fine if it is not removed. The number of lines are also decreased which is i guess not leading CodeCov build to pass. The report says PR decreased coverage by 0.09%.

@keshakaneria
Copy link
Member

keshakaneria commented Sep 23, 2020

It is still failing. cc: @gaurivn @satya7289

@sanchibansal340
Copy link

@SanketDG Can you help with why the build is failing?

@SanketDG
Copy link

Looks like some unrelated bug to me, but I could be wrong here

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the text on the landing page
4 participants