-
Notifications
You must be signed in to change notification settings - Fork 4
allowed special character in address field #1149
base: develop
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1149 +/- ##
==========================================
Coverage ? 87.20%
==========================================
Files ? 85
Lines ? 4057
Branches ? 237
==========================================
Hits ? 3538
Misses ? 448
Partials ? 71 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright! This looks good now 😄 good job!
@SanketDG can you please review |
@keshakaneria @SanketDG |
Hi any updates @isabelcosta @keshakaneria |
Any updates about the review @isabelcosta? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good, but we would like to see a description of how this is supposed to be tested, and could you also add a unit test @vaibhavarora102 ?
cc @keshakaneria
Description
allowed the special characters in the address field, using RegexValidator
Fixes #1037
Type of Change:
Code/Quality Assurance Only
How Has This Been Tested?
I had tested on local setup and it works fine
Checklist:
Delete irrelevant options.
Code/Quality Assurance Only