Skip to content
This repository has been archived by the owner on Jan 26, 2021. It is now read-only.

Deployed to Heroku and created Instruction for Heroku Deployment #1159

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

DARK-art108
Copy link

Description

Deploy the web app to Heroku, this will be helpful for testers.

Fixes #1135

Type of Change:

Delete irrelevant options.

  • Code
  • Documentation

Code/Quality Assurance Only

  • This change requires a documentation update (software upgrade on readme file)
  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

The Heroku app is deployed on https://vms-r.herokuapp.com/ and tested

Checklist:

Delete irrelevant options.

  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas

Code/Quality Assurance Only

  • My changes generate no new warnings
  • My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been published in downstream modules

@codecov
Copy link

codecov bot commented Oct 27, 2020

Codecov Report

Merging #1159 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1159   +/-   ##
========================================
  Coverage    87.18%   87.18%           
========================================
  Files           85       85           
  Lines         4057     4057           
  Branches       237      237           
========================================
  Hits          3537     3537           
+ Misses         450      449    -1     
- Partials        70       71    +1     
Impacted Files Coverage Δ
vms/event/views.py 77.63% <0.00%> (-1.69%) ⬇️
vms/shift/views.py 63.40% <0.00%> (+0.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0189ce8...641ee3b. Read the comment docs.

Copy link
Member

@isabelcosta isabelcosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, I want to look more into the instructions, but you validated something I was suspecting, there are changes needed in the code to make it automatically used by Heroku. Can you create those files as part of your changes and add them to this PR, please?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deploy to Heroku and write instructions on how to do that
2 participants