[issue-145] - update to java 17 (finnyb#146)

.github/workflows/build.yml

@@ -13,10 +13,10 @@ jobs:
       - uses: actions/checkout@v2
         with:
           fetch-depth: 0  # Shallow clones should be disabled for a better relevancy of analysis
-      - name: Set up JDK 11
+      - name: Set up JDK 17
         uses: actions/setup-java@v1
         with:
-          java-version: 11
+          java-version: 17
       - name: Cache SonarCloud packages
         uses: actions/cache@v1
         with:

pom.xml

@@ -95,8 +95,8 @@
                 <artifactId>maven-compiler-plugin</artifactId>
                 <version>3.10.1</version>
                 <configuration>
-                    <source>11</source>
-                    <target>11</target>
+                    <source>17</source>
+                    <target>17</target>
                 </configuration>
             </plugin>
             <plugin>
@@ -205,7 +205,7 @@
                     </formats>
                     <java>
                         <googleJavaFormat>
-                            <version>1.8</version>
+                            <version>1.15.0</version>
                             <reflowLongStrings>true</reflowLongStrings>
                         </googleJavaFormat>
                     </java>

src/main/java/org/bff/javampd/command/CommandExecutor.java

@@ -4,9 +4,11 @@
 import java.util.List;
 import org.bff.javampd.server.MPD;
 
-/** @author bill */
+/**
+ * @author bill
+ */
 public interface CommandExecutor {
-  static String COMMAND_TERMINATION = "OK";
+  String COMMAND_TERMINATION = "OK";
   /**
    * Sends a command with no parameters to the {@link org.bff.javampd.server.MPD} server returning
    * the response as a <CODE>List</CODE> of <CODE>Strings</CODE>.

src/main/java/org/bff/javampd/database/DatabaseProperties.java

@@ -2,7 +2,9 @@
 
 import org.bff.javampd.server.MPDProperties;
 
-/** @author bill */
+/**
+ * @author bill
+ */
 public class DatabaseProperties extends MPDProperties {
   private enum Command {
     FIND("db.find"),

src/main/java/org/bff/javampd/monitor/StandAloneMonitor.java

@@ -9,7 +9,9 @@
 import org.bff.javampd.server.ConnectionChangeListener;
 import org.bff.javampd.server.ErrorListener;
 
-/** @author bill */
+/**
+ * @author bill
+ */
 public interface StandAloneMonitor {
   /**
    * Adds a {@link org.bff.javampd.player.TrackPositionChangeListener} to this object to receive

src/main/java/org/bff/javampd/player/Player.java

@@ -4,7 +4,9 @@
 import org.bff.javampd.audioinfo.MPDAudioInfo;
 import org.bff.javampd.playlist.MPDPlaylistSong;
 
-/** @author bill */
+/**
+ * @author bill
+ */
 public interface Player {
 
   /** The status of the player. */
@@ -13,7 +15,7 @@ enum Status {
     STATUS_PLAYING("play"),
     STATUS_PAUSED("pause");
 
-    private String prefix;
+    private final String prefix;
 
     Status(String prefix) {
       this.prefix = prefix;

src/main/java/org/bff/javampd/playlist/Playlist.java

@@ -7,7 +7,9 @@
 import org.bff.javampd.genre.MPDGenre;
 import org.bff.javampd.song.MPDSong;
 
-/** @author bill */
+/**
+ * @author bill
+ */
 public interface Playlist {
   /**
    * Adds a {@link PlaylistChangeListener} to this object to receive {@link PlaylistChangeEvent}s.

src/main/java/org/bff/javampd/playlist/PlaylistProperties.java

@@ -2,7 +2,9 @@
 
 import org.bff.javampd.server.MPDProperties;
 
-/** @author bill */
+/**
+ * @author bill
+ */
 public class PlaylistProperties extends MPDProperties {
 
   private enum Command {

src/main/java/org/bff/javampd/playlist/PlaylistSongConverter.java

@@ -3,7 +3,9 @@
 import java.util.List;
 import org.bff.javampd.song.MPDSong;
 
-/** @author bill */
+/**
+ * @author bill
+ */
 public interface PlaylistSongConverter {
   /**
    * Converts the response from the MPD server into {@link MPDSong}s.

src/main/java/org/bff/javampd/server/MPDSocket.java

@@ -16,7 +16,9 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-/** @author bill */
+/**
+ * @author bill
+ */
 @Slf4j
 public class MPDSocket {
   private static final Logger LOGGER = LoggerFactory.getLogger(MPDSocket.class);

src/main/java/org/bff/javampd/server/Server.java

@@ -9,7 +9,9 @@
 import org.bff.javampd.song.SongSearcher;
 import org.bff.javampd.statistics.ServerStatistics;
 
-/** @author bill */
+/**
+ * @author bill
+ */
 public interface Server {
   /**
    * Clears the current error message in the MPD status

src/main/java/org/bff/javampd/server/ServerProperties.java

@@ -1,6 +1,8 @@
 package org.bff.javampd.server;
 
-/** @author bill */
+/**
+ * @author bill
+ */
 public class ServerProperties extends MPDProperties {
 
   private enum Command {

src/main/java/org/bff/javampd/song/SearchProperties.java

@@ -2,7 +2,9 @@
 
 import org.bff.javampd.server.MPDProperties;
 
-/** @author bill */
+/**
+ * @author bill
+ */
 public class SearchProperties extends MPDProperties {
   private enum Command {
     FIND("db.find"),

src/main/java/org/bff/javampd/song/SongConverter.java

@@ -2,7 +2,9 @@
 
 import java.util.List;
 
-/** @author bill */
+/**
+ * @author bill
+ */
 public interface SongConverter {
   /**
    * Converts the response from the MPD server into {@link MPDSong}s.

src/main/java/org/bff/javampd/statistics/MPDServerStatistics.java

@@ -5,7 +5,9 @@
 import org.bff.javampd.command.CommandExecutor;
 import org.bff.javampd.server.ServerProperties;
 
-/** @author bill */
+/**
+ * @author bill
+ */
 @Slf4j
 public class MPDServerStatistics implements ServerStatistics {
 

src/main/java/org/bff/javampd/statistics/ServerStatistics.java

@@ -1,6 +1,8 @@
 package org.bff.javampd.statistics;
 
-/** @author bill */
+/**
+ * @author bill
+ */
 public interface ServerStatistics {
   MPDStatistics getStatistics();
 }

src/test/java/org/bff/javampd/album/MPDAlbumTest.java

@@ -11,7 +11,9 @@
 import org.junit.jupiter.api.DisplayName;
 import org.junit.jupiter.api.Test;
 
-/** @author Bill */
+/**
+ * @author Bill
+ */
 class MPDAlbumTest {
   @Test
   @DisplayName("add artist using default list")