refactor(src/es): Improvements for the main spanish extensions (part 2) #2474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmir1
requested changes
Nov 6, 2023
| episode_number = formatedEp | ||
| name = "Episodio $formatedEp" | ||
| } | ||
| }.reversed() | ||
| } | ||
|
|
||
| override fun videoListParse(response: Response): List<Video> { | ||
| val document = response.asJsoup() | ||
| val videoList = mutableListOf<Video>() | ||
| document.select("div.playermain ul.dropcaps li#play-video a.cap").forEach { players -> |
There was a problem hiding this comment.
I think if you're using this many extractors, you should parallelize this loop.
Same for the other sources in this loop.
Claudemirovsky
requested changes
Nov 6, 2023
Comment on lines
+41
to
42
| override val name = "DoramasYT" | ||
|
|
There was a problem hiding this comment.
- Have explicitly kept the id if a source's name or language were changed
Suggested change
| override val name = "DoramasYT" | |
| override val name = "DoramasYT" | |
| override val id = 885919523581666049L |
Comment on lines
+71
to
+92
| override fun popularAnimeParse(response: Response): AnimesPage { | ||
| val url = response.request.url.toString() | ||
| val document = response.asJsoup() | ||
| val elements = document.select("div.col-lg-2.col-md-4.col-6 div.animes") | ||
| val nextPage = document.select("ul.pagination li:last-child a").any() | ||
| val animeList = elements.map { element -> | ||
| SAnime.create().apply { | ||
| setUrlWithoutDomain( | ||
| when { | ||
| url.contains("emision") -> element.select("a").attr("abs:href") | ||
| else -> element.select("div.anithumb a").attr("abs:href") | ||
| }, | ||
| ) | ||
| title = element.select("div.animedtls p").text() | ||
| description = element.select("div.animedtls p").text() | ||
| thumbnail_url = when { | ||
| url.contains("emision") -> element.select("a > img").attr("abs:src") | ||
| else -> element.select(".anithumb a img").attr("abs:src") | ||
| } | ||
| } | ||
| } | ||
| return AnimesPage(animeList, nextPage) |
There was a problem hiding this comment.
If you're going to use Jsoup(document selectors and etc), then the source class should be a ParsedAnimeHttpSource and you should use it's jsoup-related functions, in this case it would look like this:
override fun popularAnimeSelector() = "div.col-lg-2.col-md-4.col-6 div.animes"
override fun popularAnimeFromElement(element: Element) = SAnime.create().apply {
val urlElement = element.selectFirst("a")!!
setUrlWithoutDomain(urlElement.attr("href"))
title = element.selectFirst("div.animedtls p")!!.text()
thumbnail_url = urlElement.selectFirst("img")?.absUrl("src")
}
override fun popularAnimeNextPageSelector() = "ul.pagination li:last-child a"| override fun episodeListParse(response: Response): List<SEpisode> { | ||
| return super.episodeListParse(response).reversed() | ||
| } | ||
| override fun latestUpdatesParse(response: Response) = popularAnimeParse(response) |
There was a problem hiding this comment.
^ this also would work with the previous example
Comment on lines
+109
to
+122
| override fun searchAnimeParse(response: Response): AnimesPage { | ||
| val document = response.asJsoup() | ||
| val elements = document.select("div.col-lg-2.col-md-4.col-6 div.animes") | ||
| val nextPage = document.select("ul.pagination li:last-child a").any() | ||
| val animeList = elements.map { element -> | ||
| SAnime.create().apply { | ||
| setUrlWithoutDomain(element.selectFirst("a")!!.attr("href")) | ||
| title = element.select("div.animedtls p").text() | ||
| thumbnail_url = element.select("a img").attr("src") | ||
| description = element.select("div.animedtls p").text() | ||
| } | ||
| } | ||
| episode.setUrlWithoutDomain(element.select("a").attr("href")) | ||
| episode.episode_number = formatedEp | ||
| episode.name = "Episodio $formatedEp" | ||
| return AnimesPage(animeList, nextPage) | ||
| } |
There was a problem hiding this comment.
That's pratically the same code you wrote in popularAnimeParse(response); why not just reuse it?
(also, this version would work with popular/latest anime pages just fine too)
| else -> 1F | ||
| } | ||
| SEpisode.create().apply { | ||
| setUrlWithoutDomain(element.select("a").attr("abs:href")) |
There was a problem hiding this comment.
you don't need the absolute url, setUrlWithoutDomain will save only the path (as it's name says).
Ex: https://doramayt.com/ihatetheantichrist -> /ihatetheantichrist
Comment on lines
+168
to
236
| if (embedUrl.contains("voe")) { | ||
| VoeExtractor(client).videoFromUrl(url, prefix = "Voe:")?.let { videoList.add(it) } | ||
| } | ||
| if ((embedUrl.contains("amazon") || embedUrl.contains("amz")) && !embedUrl.contains("disable")) { | ||
| val video = amazonExtractor(baseUrl + url.substringAfter("..")) | ||
| if (video.isNotBlank()) { | ||
| if (url.contains("&ext=es")) { | ||
| videoList.add(Video(video, "AmazonES", video)) | ||
| } else { | ||
| videoList.add(Video(video, "Amazon", video)) | ||
| } | ||
| } | ||
| } | ||
| if (server.contains("ok")) { | ||
| val videos = OkruExtractor(client).videosFromUrl(url) | ||
| videoList.addAll(videos) | ||
| if (embedUrl.contains("ok.ru") || embedUrl.contains("okru")) { | ||
| runCatching { | ||
| OkruExtractor(client).videosFromUrl(url).also(videoList::addAll) | ||
| } | ||
| } | ||
| if (embedUrl.contains("filemoon") || embedUrl.contains("moonplayer")) { | ||
| val vidHeaders = headers.newBuilder() | ||
| .add("Origin", "https://${url.toHttpUrl().host}") | ||
| .add("Referer", "https://${url.toHttpUrl().host}/") | ||
| .build() | ||
| FilemoonExtractor(client).videosFromUrl(url, prefix = "Filemoon:", headers = vidHeaders).also(videoList::addAll) | ||
| } | ||
| if (embedUrl.contains("uqload") || embedUrl.contains("upload")) { | ||
| UqloadExtractor(client).videosFromUrl(url).also(videoList::addAll) | ||
| } | ||
| if (embedUrl.contains("mp4upload")) { | ||
| Mp4uploadExtractor(client).videosFromUrl(url, headers).let { videoList.addAll(it) } | ||
| } | ||
| if (embedUrl.contains("wishembed") || embedUrl.contains("embedwish") || embedUrl.contains("streamwish") || embedUrl.contains("strwish") || embedUrl.contains("wish")) { | ||
| val docHeaders = headers.newBuilder() | ||
| .add("Origin", "https://streamwish.to") | ||
| .add("Referer", "https://streamwish.to/") | ||
| .build() | ||
| StreamWishExtractor(client, docHeaders).videosFromUrl(url, videoNameGen = { "StreamWish:$it" }).also(videoList::addAll) | ||
| } | ||
| if (embedUrl.contains("doodstream") || embedUrl.contains("dood.")) { | ||
| DoodExtractor(client).videoFromUrl(url, "DoodStream", false)?.let { videoList.add(it) } | ||
| } | ||
| if (embedUrl.contains("streamlare")) { | ||
| StreamlareExtractor(client).videosFromUrl(url).let { videoList.addAll(it) } | ||
| } | ||
| if (embedUrl.contains("yourupload") || embedUrl.contains("upload")) { | ||
| YourUploadExtractor(client).videoFromUrl(url, headers = headers).let { videoList.addAll(it) } | ||
| } | ||
| if (embedUrl.contains("burstcloud") || embedUrl.contains("burst")) { | ||
| BurstCloudExtractor(client).videoFromUrl(url, headers = headers).let { videoList.addAll(it) } | ||
| } | ||
| if (embedUrl.contains("fastream")) { | ||
| FastreamExtractor(client, headers).videosFromUrl(url).also(videoList::addAll) | ||
| } | ||
| if (embedUrl.contains("upstream")) { | ||
| UpstreamExtractor(client).videosFromUrl(url).let { videoList.addAll(it) } | ||
| } | ||
| if (embedUrl.contains("streamtape") || embedUrl.contains("stp") || embedUrl.contains("stape")) { | ||
| StreamTapeExtractor(client).videoFromUrl(url)?.let { videoList.add(it) } | ||
| } | ||
| if (server.contains("zeus")) { | ||
| if (embedUrl.contains("ahvsh") || embedUrl.contains("streamhide")) { | ||
| StreamHideVidExtractor(client).videosFromUrl(url).let { videoList.addAll(it) } | ||
| } | ||
| if (embedUrl.contains("filelions") || embedUrl.contains("lion")) { | ||
| StreamWishExtractor(client, headers).videosFromUrl(url, videoNameGen = { "FileLions:$it" }).also(videoList::addAll) | ||
| } | ||
| if (embedUrl.contains("solid")) { | ||
| val videos = SolidFilesExtractor(client).videosFromUrl(url) | ||
| videoList.addAll(videos) | ||
| } |
There was a problem hiding this comment.
A URL won't work on more than one extractor, so you should be using else ifs instead of only ifs.
Personally I'd recommend using a when {} block, but that's up to you.
Comment on lines
+145
to
+210
| if (embedUrl.contains("voe")) { | ||
| VoeExtractor(client).videoFromUrl(url, prefix = "Voe:")?.let { videoList.add(it) } | ||
| } | ||
| if (embedUrl.contains("streamlare")) { | ||
| try { | ||
| StreamlareExtractor(client).videosFromUrl(url)?.let { | ||
| videoList.add(it) | ||
| if ((embedUrl.contains("amazon") || embedUrl.contains("amz")) && !embedUrl.contains("disable")) { | ||
| val video = amazonExtractor(baseUrl + url.substringAfter("..")) | ||
| if (video.isNotBlank()) { | ||
| if (url.contains("&ext=es")) { | ||
| videoList.add(Video(video, "AmazonES", video)) | ||
| } else { | ||
| videoList.add(Video(video, "Amazon", video)) | ||
| } | ||
| } catch (_: Exception) {} | ||
| } | ||
| if (embedUrl.contains("doodstream") || embedUrl.contains("dood")) { | ||
| val video = try { | ||
| DoodExtractor(client).videoFromUrl(url, "DoodStream", true) | ||
| } catch (e: Exception) { | ||
| null | ||
| } | ||
| if (video != null) { | ||
| videoList.add(video) | ||
| } | ||
| if (embedUrl.contains("ok.ru") || embedUrl.contains("okru")) { | ||
| runCatching { | ||
| OkruExtractor(client).videosFromUrl(url).also(videoList::addAll) | ||
| } | ||
| } | ||
| if (embedUrl.contains("okru") || embedUrl.contains("ok.ru")) { | ||
| val videos = OkruExtractor(client).videosFromUrl(url) | ||
| videoList.addAll(videos) | ||
| if (embedUrl.contains("filemoon") || embedUrl.contains("moonplayer")) { | ||
| val vidHeaders = headers.newBuilder() | ||
| .add("Origin", "https://${url.toHttpUrl().host}") | ||
| .add("Referer", "https://${url.toHttpUrl().host}/") | ||
| .build() | ||
| FilemoonExtractor(client).videosFromUrl(url, prefix = "Filemoon:", headers = vidHeaders).also(videoList::addAll) | ||
| } | ||
| } | ||
| if (embedUrl.contains("uqload") || embedUrl.contains("upload")) { | ||
| UqloadExtractor(client).videosFromUrl(url).also(videoList::addAll) | ||
| } | ||
| if (embedUrl.contains("mp4upload")) { | ||
| Mp4uploadExtractor(client).videosFromUrl(url, headers).let { videoList.addAll(it) } | ||
| } | ||
| if (embedUrl.contains("wishembed") || embedUrl.contains("embedwish") || embedUrl.contains("streamwish") || embedUrl.contains("strwish") || embedUrl.contains("wish")) { | ||
| val docHeaders = headers.newBuilder() | ||
| .add("Origin", "https://streamwish.to") | ||
| .add("Referer", "https://streamwish.to/") | ||
| .build() | ||
| StreamWishExtractor(client, docHeaders).videosFromUrl(url, videoNameGen = { "StreamWish:$it" }).also(videoList::addAll) | ||
| } | ||
| if (embedUrl.contains("doodstream") || embedUrl.contains("dood.")) { | ||
| DoodExtractor(client).videoFromUrl(url, "DoodStream", false)?.let { videoList.add(it) } | ||
| } | ||
| if (embedUrl.contains("streamlare")) { | ||
| StreamlareExtractor(client).videosFromUrl(url).let { videoList.addAll(it) } | ||
| } | ||
| if (embedUrl.contains("yourupload") || embedUrl.contains("upload")) { | ||
| YourUploadExtractor(client).videoFromUrl(url, headers = headers).let { videoList.addAll(it) } | ||
| } | ||
| if (embedUrl.contains("burstcloud") || embedUrl.contains("burst")) { | ||
| BurstCloudExtractor(client).videoFromUrl(url, headers = headers).let { videoList.addAll(it) } | ||
| } | ||
| if (embedUrl.contains("fastream")) { | ||
| FastreamExtractor(client, headers).videosFromUrl(url).also(videoList::addAll) | ||
| } | ||
| if (embedUrl.contains("upstream")) { | ||
| UpstreamExtractor(client).videosFromUrl(url).let { videoList.addAll(it) } | ||
| } | ||
| if (embedUrl.contains("streamtape") || embedUrl.contains("stp") || embedUrl.contains("stape")) { | ||
| StreamTapeExtractor(client).videoFromUrl(url)?.let { videoList.add(it) } | ||
| } | ||
| if (embedUrl.contains("ahvsh") || embedUrl.contains("streamhide")) { | ||
| StreamHideVidExtractor(client).videosFromUrl(url).let { videoList.addAll(it) } | ||
| } | ||
| if (embedUrl.contains("filelions") || embedUrl.contains("lion")) { | ||
| StreamWishExtractor(client, headers).videosFromUrl(url, videoNameGen = { "FileLions:$it" }).also(videoList::addAll) | ||
| } | ||
| } catch (_: Exception) { } |
There was a problem hiding this comment.
As said before, use else ifs or a when {} block instead of a trillion open ifs.
Also, as jmir said, you should try parallelizing the extractor, because loading this all wiill take decades.
Comment on lines
+272
to
+282
| document.select(".mvic-info .mvici-left p").map { | ||
| if (it.select("strong").text().contains("Genre", true)) { | ||
| anime.genre = it.select("a").joinToString { it.text() } | ||
| } | ||
| if (it.select("strong").text().contains("Actors", true)) { | ||
| anime.artist = it.selectFirst("a")?.text() ?: "" | ||
| } | ||
| if (it.select("strong").text().contains("Studio", true)) { | ||
| anime.author = it.selectFirst("a")?.text() ?: "" | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| document.select(".mvic-info .mvici-left p").map { | |
| if (it.select("strong").text().contains("Genre", true)) { | |
| anime.genre = it.select("a").joinToString { it.text() } | |
| } | |
| if (it.select("strong").text().contains("Actors", true)) { | |
| anime.artist = it.selectFirst("a")?.text() ?: "" | |
| } | |
| if (it.select("strong").text().contains("Studio", true)) { | |
| anime.author = it.selectFirst("a")?.text() ?: "" | |
| } | |
| } | |
| document.select(".mvic-info .mvici-left p").forEach { | |
| val text = it.selectFirst("strong")?.text() ?: return@forEach | |
| when { | |
| text.contains("Genre", true) -> anime.genre = it.select("a").joinToString { it.text() } | |
| text.contains("Actors", true) -> anime.artist = it.selectFirst("a")?.text() | |
| text.contains("Studio", true) -> anime.author = it.selectFirst("a")?.text() | |
| } | |
| } |
Comment on lines
+313
to
+380
| if (embedUrl.contains("voe")) { | ||
| VoeExtractor(client).videoFromUrl(url, prefix = "Voe:")?.let { videoList.add(it) } | ||
| } | ||
| if ((embedUrl.contains("amazon") || embedUrl.contains("amz")) && !embedUrl.contains("disable")) { | ||
| val video = amazonExtractor(baseUrl + url.substringAfter("..")) | ||
| if (video.isNotBlank()) { | ||
| if (url.contains("&ext=es")) { | ||
| videoList.add(Video(video, "AmazonES", video)) | ||
| } else { | ||
| videoList.add(Video(video, "Amazon", video)) | ||
| } | ||
| } | ||
| url.contains("yourupload") -> { | ||
| val videos = YourUploadExtractor(client).videoFromUrl(url, headers = headers, name = "Original", prefix = prefix) | ||
| videoList.addAll(videos) | ||
| } | ||
| if (embedUrl.contains("ok.ru") || embedUrl.contains("okru")) { | ||
| runCatching { | ||
| OkruExtractor(client).videosFromUrl(url).also(videoList::addAll) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| return videoList.sort() | ||
| if (embedUrl.contains("filemoon") || embedUrl.contains("moonplayer")) { | ||
| val vidHeaders = headers.newBuilder() | ||
| .add("Origin", "https://${url.toHttpUrl().host}") | ||
| .add("Referer", "https://${url.toHttpUrl().host}/") | ||
| .build() | ||
| FilemoonExtractor(client).videosFromUrl(url, prefix = "Filemoon:", headers = vidHeaders).also(videoList::addAll) | ||
| } | ||
| if (embedUrl.contains("uqload") || embedUrl.contains("upload")) { | ||
| UqloadExtractor(client).videosFromUrl(url).also(videoList::addAll) | ||
| } | ||
| if (embedUrl.contains("mp4upload")) { | ||
| Mp4uploadExtractor(client).videosFromUrl(url, headers).let { videoList.addAll(it) } | ||
| } | ||
| if (embedUrl.contains("wishembed") || embedUrl.contains("embedwish") || embedUrl.contains("streamwish") || embedUrl.contains("strwish") || embedUrl.contains("wish")) { | ||
| val docHeaders = headers.newBuilder() | ||
| .add("Origin", "https://streamwish.to") | ||
| .add("Referer", "https://streamwish.to/") | ||
| .build() | ||
| StreamWishExtractor(client, docHeaders).videosFromUrl(url, videoNameGen = { "StreamWish:$it" }).also(videoList::addAll) | ||
| } | ||
| if (embedUrl.contains("doodstream") || embedUrl.contains("dood.")) { | ||
| DoodExtractor(client).videoFromUrl(url, "DoodStream", false)?.let { videoList.add(it) } | ||
| } | ||
| if (embedUrl.contains("streamlare")) { | ||
| StreamlareExtractor(client).videosFromUrl(url).let { videoList.addAll(it) } | ||
| } | ||
| if (embedUrl.contains("yourupload") || embedUrl.contains("upload")) { | ||
| YourUploadExtractor(client).videoFromUrl(url, headers = headers).let { videoList.addAll(it) } | ||
| } | ||
| if (embedUrl.contains("burstcloud") || embedUrl.contains("burst")) { | ||
| BurstCloudExtractor(client).videoFromUrl(url, headers = headers).let { videoList.addAll(it) } | ||
| } | ||
| if (embedUrl.contains("fastream")) { | ||
| FastreamExtractor(client, headers).videosFromUrl(url).also(videoList::addAll) | ||
| } | ||
| if (embedUrl.contains("upstream")) { | ||
| UpstreamExtractor(client).videosFromUrl(url).let { videoList.addAll(it) } | ||
| } | ||
| if (embedUrl.contains("streamtape") || embedUrl.contains("stp") || embedUrl.contains("stape")) { | ||
| StreamTapeExtractor(client).videoFromUrl(url)?.let { videoList.add(it) } | ||
| } | ||
| if (embedUrl.contains("ahvsh") || embedUrl.contains("streamhide")) { | ||
| StreamHideVidExtractor(client).videosFromUrl(url).let { videoList.addAll(it) } | ||
| } | ||
| if (embedUrl.contains("filelions") || embedUrl.contains("lion")) { | ||
| StreamWishExtractor(client, headers).videosFromUrl(url, videoNameGen = { "FileLions:$it" }).also(videoList::addAll) | ||
| } | ||
| if (embedUrl.contains("mixdrop")) { | ||
| MixDropExtractor(client).videosFromUrl(url).let { videoList.addAll(it) } | ||
| } |
There was a problem hiding this comment.
Are you an if lover?
Comment on lines
+125
to
194
| if (embedUrl.contains("voe")) { | ||
| VoeExtractor(client).videoFromUrl(url, prefix = "Voe:")?.let { videoList.add(it) } | ||
| } | ||
| if ((embedUrl.contains("amazon") || embedUrl.contains("amz")) && !embedUrl.contains("disable")) { | ||
| val video = amazonExtractor(baseUrl + url.substringAfter("..")) | ||
| if (video.isNotBlank()) { | ||
| if (url.contains("&ext=es")) { | ||
| videoList.add(Video(video, "AmazonES", video)) | ||
| } else { | ||
| videoList.add(Video(video, "Amazon", video)) | ||
| } | ||
| } | ||
| "yourupload" -> { | ||
| videoList.addAll( | ||
| YourUploadExtractor(client).videoFromUrl(serverUrl, headers = headers), | ||
| ) | ||
| } | ||
| if (embedUrl.contains("ok.ru") || embedUrl.contains("okru")) { | ||
| runCatching { | ||
| OkruExtractor(client).videosFromUrl(url).also(videoList::addAll) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| if (embedUrl.contains("filemoon") || embedUrl.contains("moonplayer")) { | ||
| val vidHeaders = headers.newBuilder() | ||
| .add("Origin", "https://${url.toHttpUrl().host}") | ||
| .add("Referer", "https://${url.toHttpUrl().host}/") | ||
| .build() | ||
| FilemoonExtractor(client).videosFromUrl(url, prefix = "Filemoon:", headers = vidHeaders).also(videoList::addAll) | ||
| } | ||
| if (embedUrl.contains("uqload") || embedUrl.contains("upload")) { | ||
| UqloadExtractor(client).videosFromUrl(url).also(videoList::addAll) | ||
| } | ||
| if (embedUrl.contains("mp4upload")) { | ||
| Mp4uploadExtractor(client).videosFromUrl(url, headers).let { videoList.addAll(it) } | ||
| } | ||
| if (embedUrl.contains("wishembed") || embedUrl.contains("embedwish") || embedUrl.contains("streamwish") || embedUrl.contains("strwish") || embedUrl.contains("wish")) { | ||
| val docHeaders = headers.newBuilder() | ||
| .add("Origin", "https://streamwish.to") | ||
| .add("Referer", "https://streamwish.to/") | ||
| .build() | ||
| StreamWishExtractor(client, docHeaders).videosFromUrl(url, videoNameGen = { "StreamWish:$it" }).also(videoList::addAll) | ||
| } | ||
| if (embedUrl.contains("doodstream") || embedUrl.contains("dood.")) { | ||
| DoodExtractor(client).videoFromUrl(url, "DoodStream", false)?.let { videoList.add(it) } | ||
| } | ||
| if (embedUrl.contains("streamlare")) { | ||
| StreamlareExtractor(client).videosFromUrl(url).let { videoList.addAll(it) } | ||
| } | ||
| if (embedUrl.contains("yourupload") || embedUrl.contains("upload")) { | ||
| YourUploadExtractor(client).videoFromUrl(url, headers = headers).let { videoList.addAll(it) } | ||
| } | ||
| if (embedUrl.contains("burstcloud") || embedUrl.contains("burst")) { | ||
| BurstCloudExtractor(client).videoFromUrl(url, headers = headers).let { videoList.addAll(it) } | ||
| } | ||
| if (embedUrl.contains("fastream")) { | ||
| FastreamExtractor(client, headers).videosFromUrl(url).also(videoList::addAll) | ||
| } | ||
| if (embedUrl.contains("upstream")) { | ||
| UpstreamExtractor(client).videosFromUrl(url).let { videoList.addAll(it) } | ||
| } | ||
| if (embedUrl.contains("streamtape") || embedUrl.contains("stp") || embedUrl.contains("stape")) { | ||
| StreamTapeExtractor(client).videoFromUrl(url)?.let { videoList.add(it) } | ||
| } | ||
| if (embedUrl.contains("ahvsh") || embedUrl.contains("streamhide")) { | ||
| StreamHideVidExtractor(client).videosFromUrl(url).let { videoList.addAll(it) } | ||
| } | ||
| if (embedUrl.contains("filelions") || embedUrl.contains("lion")) { | ||
| StreamWishExtractor(client, headers).videosFromUrl(url, videoNameGen = { "FileLions:$it" }).also(videoList::addAll) | ||
| } | ||
| if (embedUrl.contains("vembed") || embedUrl.contains("guard")) { | ||
| VidGuardExtractor(client).videosFromUrl(url).also(videoList::addAll) | ||
| } | ||
| } catch (_: Exception) { } | ||
| return videoList |
There was a problem hiding this comment.
ctrl+c ctrl+v go BRRRRRRRRRRRRT
Are these sources really ALL using those hosters and really needing to implement this many extractors? Or you just wanted to implement everything imaginable just to make sure?
bapeey
reviewed
Nov 6, 2023
Comment on lines
+203
to
+207
| return try { | ||
| if (client.newCall(GET(videoURl)).execute().code == 200) videoURl else "" | ||
| } catch (e: Exception) { | ||
| "" | ||
| } |
There was a problem hiding this comment.
Doesn't the app check for this?
bapeey
reviewed
Nov 6, 2023
Comment on lines
+249
to
+250
| anime.thumbnail_url = document.select(".thumb img").attr("abs:src") | ||
| anime.status = parseStatus(document.select(".btn-block.status").text()) |
There was a problem hiding this comment.
No need to create the variable
override fun animeDetailsParse(document: Document): SAnime = SAnime.create().apply {
title = document.select("h1.title").text()
....
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Closes #2392
Closes #2407
Closes #2409
Closes #2410
Closes #2362
extVersionCodevalue inbuild.gradlefor individual extensionsoverrideVersionCodeorbaseVersionCodeas needed for all multisrc extensionsisNsfw = trueflag inbuild.gradlewhen appropriateidif a source's name or language were changed