fix(pt/animesonline): Rename + Update baseUrl + Fix extractors #3301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Secozzi
reviewed
Jun 3, 2024
Comment on lines
+89
to
+91
| val iframe = player.root().selectFirst("div#source-player-$playerId iframe") | ||
|
|
||
| return iframe?.attr("src")?.takeIf(String::isNotBlank) |
There was a problem hiding this comment.
Suggested change
| val iframe = player.root().selectFirst("div#source-player-$playerId iframe") | |
| return iframe?.attr("src")?.takeIf(String::isNotBlank) | |
| val iframe = player.root().selectFirst("div#source-player-$playerId iframe[src]") | |
| return iframe?.attr("src") |
There was a problem hiding this comment.
the problem isn't the lack of the src attribute. This source is cursed enough to sometimes put a <iframe src="">
There was a problem hiding this comment.
how about iframe[src~=.] then
There was a problem hiding this comment.
still matches a src=" ", but I never saw this in the source (yet) so I guess it's safe
jmir1
approved these changes
Jun 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3289
Checklist:
extVersionCodevalue inbuild.gradlefor individual extensionsoverrideVersionCodeorbaseVersionCodeas needed for all multisrc extensionsisNsfw = trueflag inbuild.gradlewhen appropriateidif a source's name or language were changedweb_hi_res_512.pngwhen adding a new extension