add warning about experimental PiP mode

aniyomiorg · Nov 26, 2021 · 966172d · 966172d
1 parent bc4fd7b
commit 966172d
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml
@@ -95,8 +95,6 @@
             android:theme="@style/Theme.AppCompat.Light.NoActionBar.FullScreen"
             android:supportsPictureInPicture="true"
             android:resizeableActivity="true"
-            android:excludeFromRecents="true"
-            android:taskAffinity=".PlayerActivity"
             android:configChanges="keyboardHidden|orientation|screenSize|screenLayout|smallestScreenSize"
             android:screenOrientation="userLandscape"
             android:launchMode="singleTask"

diff --git a/app/src/main/java/eu/kanade/tachiyomi/ui/setting/SettingsPlayerController.kt b/app/src/main/java/eu/kanade/tachiyomi/ui/setting/SettingsPlayerController.kt
@@ -5,6 +5,7 @@ import eu.kanade.tachiyomi.R
 import eu.kanade.tachiyomi.util.preference.defaultValue
 import eu.kanade.tachiyomi.util.preference.entriesRes
 import eu.kanade.tachiyomi.util.preference.listPreference
+import eu.kanade.tachiyomi.util.preference.summaryRes
 import eu.kanade.tachiyomi.util.preference.switchPreference
 import eu.kanade.tachiyomi.util.preference.titleRes
 import eu.kanade.tachiyomi.data.preference.PreferenceKeys as Keys
@@ -97,6 +98,7 @@ class SettingsPlayerController : SettingsController() {
         switchPreference {
             key = Keys.pipPlayerPreference
             titleRes = R.string.pref_pip_player
+            summaryRes = R.string.pref_pip_player_summary
             defaultValue = false
         }
     }

diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
@@ -429,6 +429,7 @@
     <string name="pref_skip_10">10s</string>
     <string name="pref_skip_5">5s</string>
     <string name="pref_pip_player">Enable picture in picture mode</string>
+    <string name="pref_pip_player_summary">Note: this is still an experimental feature!</string>
     <string name="pref_always_use_external_player">Always use external player</string>
     <string name="pref_external_player_preference">External player preference</string>
     <string name="pref_progress_70">70%</string>