Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use respond_to_missing? instead of respond_to? #19

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

joshmenden
Copy link
Contributor

@joshmenden joshmenden commented Oct 31, 2024

It's considered best practice since ruby 1.9.2 to define a respond_to_missing? method instead of just a respond_to? when you have a method_missing method defined. Small update here to do that!

@joshmenden joshmenden mentioned this pull request Oct 31, 2024
@ankane ankane merged commit ea56928 into ankane:master Oct 31, 2024
1 check passed
@ankane
Copy link
Owner

ankane commented Oct 31, 2024

Perfect, thanks @joshmenden!

@joshmenden joshmenden deleted the jmm/respond_to_missing branch October 31, 2024 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants