Improved code

ankane · Mar 3, 2024 · 7d3027f · 7d3027f
1 parent 0b401af
commit 7d3027f
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/ext/polars/src/dataframe.rs b/ext/polars/src/dataframe.rs
@@ -807,12 +807,11 @@ impl RbDataFrame {
         self.df.borrow().get_column_index(&name)
     }
 
-    // TODO remove clone
-    pub fn column(&self, name: String) -> RbResult<RbSeries> {
+    pub fn get_column(&self, name: String) -> RbResult<RbSeries> {
         self.df
             .borrow()
             .column(&name)
-            .map(|v| v.clone().into())
+            .map(|s| RbSeries::new(s.clone()))
             .map_err(RbPolarsErr::from)
     }
 

diff --git a/ext/polars/src/lib.rs b/ext/polars/src/lib.rs
@@ -228,7 +228,7 @@ fn init(ruby: &Ruby) -> RbResult<()> {
         "get_column_index",
         method!(RbDataFrame::get_column_index, 1),
     )?;
-    class.define_method("column", method!(RbDataFrame::column, 1))?;
+    class.define_method("get_column", method!(RbDataFrame::get_column, 1))?;
     class.define_method("select", method!(RbDataFrame::select, 1))?;
     class.define_method("take", method!(RbDataFrame::take, 1))?;
     class.define_method(

diff --git a/lib/polars/data_frame.rb b/lib/polars/data_frame.rb
@@ -622,7 +622,7 @@ def [](*args)
         # select single column
         # df["foo"]
         if item.is_a?(::String) || item.is_a?(Symbol)
-          return Utils.wrap_s(_df.column(item.to_s))
+          return Utils.wrap_s(_df.get_column(item.to_s))
         end
 
         # df[idx]