Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #17864 : Instant card, Double Pop of Discard Dialog Box issue #17871

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MritunjayTiwari14
Copy link

Purpose / Description

#17864 : Instant card, Double Pop of Discard Dialog Box issue

Fixes

Approach

using flag

How Has This Been Tested?

simply perform the task

Checklist

Please, go through these checks before submitting the PR.

  • [ x] You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • [x ] You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@MritunjayTiwari14
Copy link
Author

@david-allison I need some guidance on how to fix the swipe gesture with back button which simultaneously pop and closes the discard dialog box without any interaction with the user

@david-allison
Copy link
Member

@MritunjayTiwari14 I'm marked as busy on GitHub and won't be able to help, sorry

@criticalAY criticalAY self-requested a review January 26, 2025 15:18
Comment on lines +103 to +111
// private val dialogBackCallback =
// object : OnBackPressedCallback(false) {
// override fun handleOnBackPressed() {
// showDiscardChangesDialog()
// }
// }

private var isDialogVisible = false

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heya! thanks for the contribution

Why this comment?
And how does it solve the issue, did you inspect the root cause?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello!, Sorry i forgot to remove it. I kept it as a backup and to analyze it while i wrote the new code with Flag to avoid repeated call to the Function to Display Discard Dialog Box.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instant Card: Double "discard changes" window appears on Android "Back" swipe gesture
3 participants