Fix: Card Browser Border and Header Height. #17904
Open
+21
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
From what I said in Discord: why is is the border between columns extending to the headers? The before images don't have that. |
As additional columns are added to the card browser, vertical lines enhance its organization and clarity. |
xenonnn4w
added
the
Needs Author Reply
xenonnn4w
reviewed
Feb 2, 2025
xenonnn4w
added
Needs Review
and removed
Needs Author Reply
BrayanDSO
reviewed
Feb 7, 2025
| @@ -17,9 +17,10 @@ | |||
| <com.ichi2.ui.FixedTextView xmlns:android="http://schemas.android.com/apk/res/android" | |||
| android:layout_width="0dp" | |||
| android:layout_height="match_parent" | |||
| android:minHeight="48dp" | |||
There was a problem hiding this comment.
Suggested change
| android:minHeight="48dp" | |
| android:minHeight="?minTouchTargetSize" |
BrayanDSO
requested changes
Feb 7, 2025
| @@ -18,7 +18,7 @@ | |||
| <LinearLayout | |||
| android:id="@+id/browser_column_headings" | |||
| android:layout_width="match_parent" | |||
| android:background="?attr/selectableItemBackground" | |||
| android:background="@drawable/browser_heading_bottom_divider" | |||
There was a problem hiding this comment.
this breaks the ripple effect when tapping the background, so the user loses the tap feedback.
Either you could fix that in the new background you created, or you can add the border as a new View below this one
There was a problem hiding this comment.
Added the ripple effect in browser_heading_bottom_divider .
BrayanDSO
added
Needs Author Reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose / Description
Fixed the Card Browser Border and Column Header Height.
Fixes
Approach
Created drawable file for the bottom divider to improve the
Card Browser border, increased theCard Browser Header heightand improved the heading textAlignment.How Has This Been Tested?
Checklist
Please, go through these checks before submitting the PR.