DeckOption become closable if it's not loaded #17905
Open
+13
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, if you try to close the Deck Options before it's loaded, the request `anki.deckOptionsPendingChanges()` can't be executed and the deck options remain open. With this change, the deck options is automatically closed. Indeed, if the webview is not loaded, there was no change to save. This is similar to Anki's implementation.
|
I tested that it still works when the view is loaded. |
david-allison
approved these changes
Jan 30, 2025
|
Cheers! Could you add a My phone's too fast to catch this one |
mikehardy
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if you try to close the Deck Options before it's loaded, the request
anki.deckOptionsPendingChanges()can't be executed and the deck options remain open.With this change, the deck options is automatically closed. Indeed, if the webview is not loaded, there was no change to save.
This is similar to Anki's implementation.
Thanks David for fixing most of the actual issue