Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use consistent label for Whiteboard editor in "App bar buttons" page #17921

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

snowtimeglass
Copy link
Contributor

Purpose / Description

Fix discrepancy in the labels for "Whiteboard editor" option
image

Fixes

  • N/A

Approach

  • Use the same string with Reviewer, in App bar settings page
  • Remove the unused string, Whiteboard pen color

How Has This Been Tested?

Checked in physical device (Android 11)
image

Record_2025-02-07-13-35-58_7b5228b5a93c00ecba98ecb0735c59e2.mp4

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

"Settings" > "Appearance" > "App bar buttons" > "Whiteboard" > "Whiteboard pen color" actually targets "Whiteboard editor" option in Reviewer.
This commit renames the "Whiteboard pen color" label to "Whiteboard editor" for consistency.
Copy link
Contributor

github-actions bot commented Feb 7, 2025

Important

Maintainers: This PR contains Strings changes

  1. Sync Translations before merging this PR and wait for the action to complete
  2. Review and merge the auto-generated PR in order to sync all user-submitted translations
  3. Sync Translations again and merge the PR so the huge automated string changes caused by merging this PR are by themselves and easy to review

@david-allison david-allison added the Needs Second Approval Has one approval, one more approval to merge label Feb 7, 2025
@lukstbit lukstbit added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Feb 7, 2025
@lukstbit lukstbit added this pull request to the merge queue Feb 7, 2025
Merged via the queue into ankidroid:main with commit 3befa11 Feb 7, 2025
12 checks passed
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Feb 7, 2025
Copy link
Contributor

github-actions bot commented Feb 7, 2025

Maintainers: Please Sync Translations to produce a commit with only the automated changes from this PR.

Read more about updating strings on the wiki,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants