Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(new reviewer): Keybinds #17928

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

BrayanDSO
Copy link
Member

@BrayanDSO BrayanDSO commented Feb 7, 2025

Approach

  1. Generify the old reviewer keymap
  2. Implement the keybindings
  3. Implement the Show answer, Answer Again/Hard/Good/Easy, Show hint, Show all hints and Close bindable actions to ease the testing process of the PR and for general use

How Has This Been Tested?

Emulator 35 (imagine I'm using keyboard keys to do the actions below)

newrev-controls.mp4

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@BrayanDSO BrayanDSO added Needs Review Blocked by dependency Currently blocked by some other dependent / related change labels Feb 7, 2025
@BrayanDSO BrayanDSO mentioned this pull request Feb 7, 2025
5 tasks
@BrayanDSO BrayanDSO force-pushed the controls-newrev branch 2 times, most recently from 22bf1b0 to 0546723 Compare February 8, 2025 00:54
@BrayanDSO BrayanDSO marked this pull request as draft February 14, 2025 09:19
@BrayanDSO BrayanDSO removed Blocked by dependency Currently blocked by some other dependent / related change Has Conflicts labels Feb 15, 2025
@BrayanDSO BrayanDSO marked this pull request as ready for review February 15, 2025 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant