Consider cards already reviewed today when calculating new/review ratio #3423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krischerven
force-pushed
the
consider-cards-already-reviewed
branch
from
00e2689
to
d90baec
Compare
|
Sorry, I don't think this is important enough to justify a schema change. My thinking was that we might be able to use the existing counts stored in the select deck, and add them to the pending count. If that won't do, I'm not sure fixing this is worth new tables, or extracting the info from the revlog. |
I'll look into that |
krischerven
force-pushed
the
consider-cards-already-reviewed
branch
from
96f722f
to
efd4aee
Compare
…r-cards-already-reviewed
krischerven
force-pushed
the
consider-cards-already-reviewed
branch
from
59e2447
to
44e4a82
Compare
|
Thank you! Please open a new PR when you're ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3374