Change CLI behavior, update docs

ankithg03 · Mar 20, 2019 · c783c3b · c783c3b
1 parent 739f0f6
commit c783c3b
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 10 deletions.
diff --git a/src/CHANGELOG.md → CHANGELOG.md b/src/CHANGELOG.md → CHANGELOG.md
@@ -6,6 +6,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [1.1.1] - 2019-03-20
+### Changed
+- `--pq-scheme` is not setting `tcp` by default.
+- Move CHANGELOG.md to the root of the module
+- README.md
+
 ## [1.1.0] - 2019-03-20
 ### Added
 - Added custom flags to `setup:config:set` CLI command
@@ -16,8 +22,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ## [1.0.0] - 2019-03-08
 ### Added
 - Initial commit
-- Added predis/predis as dependency
-- Added persisted query support
-- Added Magento 2 module registration: ScandiPWA_PersistedQuery
-- Added `Plugin\PersistedQuery` for `Magento\GraphQl\Controller\GraphQl`
-- Added `Plugin\PersistedQuery` for `ScandiPWA\GraphQl\Controller\GraphQl`
+- predis/predis as dependency
+- persisted query support
+- Magento 2 module registration: ScandiPWA_PersistedQuery
+- `Plugin\PersistedQuery` registered for `Magento\GraphQl\Controller\GraphQl`
+- `Plugin\PersistedQuery` registered for `ScandiPWA\GraphQl\Controller\GraphQl`
diff --git a/README.md b/README.md
@@ -19,10 +19,9 @@ For the convenience there are additional flags available for `php bin/magento se
 
 `--pq-database`[mandatory] - persisted query redis database (`5` for ScandiPWA docker setup)
 
-`--pq-password`[optional, **empty password is not allowed**] - persisted query redis password
-
-`--pq-scheme`[optional, default `tcp`] - persisted query redis scheme
+`--pq-scheme`[mandatory] - persisted query redis scheme
 
+`--pq-password`[optional, **empty password is not allowed**] - persisted query redis password
 
 ### Manual configuration
 Configuration for custom Redis storage, where hashes and GraphQl documents are kept in environment config 

diff --git a/src/Setup/ConfigOptionsList.php b/src/Setup/ConfigOptionsList.php
@@ -122,8 +122,6 @@ public function createConfig(array $options, DeploymentConfig $deploymentConfig)
 
         if (isset($options[self::INPUT_KEY_PQ_SCHEME])) {
             $configData->set($this->prefixerHelper('scheme'), $options[self::INPUT_KEY_PQ_SCHEME]);
-        } elseif(!$deploymentConfig->get(self::INPUT_KEY_PQ_SCHEME)) {
-            $configData->set($this->prefixerHelper('scheme'), self::INPUT_DEFAULT_PQ_SCHEME);
         }
 
         if (isset($options[self::INPUT_KEY_PQ_PASSWORD])) {