Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abhinav assignment #15

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

abhinav-0401
Copy link

@abhinav-0401 abhinav-0401 commented Feb 11, 2022

Polyglot JS Task Submission

  • Checkpoint 1: Compare the cards of hacker and player.

20pts

  • Checkpoint 2: Keep a track of the individual scores of the hacker and player.

20pts

  • Checkpoint 3: Deploy the code to GitHub Pages.

10pts

  • Extras: You can improve UI of the game ;).

Submission

Repo
Deployed Site

@Divyansh013
Copy link
Collaborator

@shubhangi013 review please!

@shubhangi013
Copy link
Collaborator

@abhinav-0401 Amazing work! 🎊 Especially loved the message you're displaying XD
Just a suggestion: You can add many scenarios because right now, only 2 or 3 are showing up.
If you can, work with the CSS file a bit and maybe align the winning and losing messages in the center.

@abhinav-0401
Copy link
Author

@abhinav-0401 Amazing work! confetti_ball Especially loved the message you're displaying XD Just a suggestion: You can add many scenarios because right now, only 2 or 3 are showing up. If you can, work with the CSS file a bit and maybe align the winning and losing messages in the center.

Thanks! I'll be adding more scenarios soon, I didn't do it mostly out of laziness. Or you could just assume it's an easy mode feature :p . And I'll be aligning those elements too. Thanks for the suggestions!

@Divyansh013 Divyansh013 added the passed Great work label Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
passed Great work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants