Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: json generator implmentation along with a site wide search bar,… #70

Merged
merged 3 commits into from
Apr 1, 2024

Conversation

bwaklog
Copy link
Collaborator

@bwaklog bwaklog commented Mar 31, 2024

Addressing issue #62 [Json Generator]

  • Added GenerateMergedJson method to the engine package
  • Added unit tests for GenerateMergedJson
  • Added site wide search from Adhesh's branch
  • Update docs.md

Copy link

netlify bot commented Mar 31, 2024

Deploy Preview for anna-docs ready!

Name Link
🔨 Latest commit 153d37f
🔍 Latest deploy log https://app.netlify.com/sites/anna-docs/deploys/660a326fa2adb7000858cbd1
😎 Deploy Preview https://deploy-preview-70--anna-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 81
Accessibility: 100
Best Practices: 100
SEO: 82
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@bwaklog bwaklog force-pushed the feat-json-generator branch from 0146465 to 96c01e8 Compare March 31, 2024 18:12
@anirudhsudhir
Copy link
Collaborator

Made some minor changes:

  • Changed function and filename from "GenerateMergedJson()" and "merged.json" to "GenerateJSONIndex()" and "index.json"
  • Updated comments
  • Fixed spellings
  • Split search functionality into a new partial

@anirudhsudhir
Copy link
Collaborator

Implemented deep data merge

  • Copy generated JSON index to the Engine struct
  • Add authors field to Frontmatter
  • Updated tests

@anirudhsudhir anirudhsudhir merged commit 3f9b2fb into main Apr 1, 2024
6 checks passed
@anirudhsudhir anirudhsudhir deleted the feat-json-generator branch April 1, 2024 04:08
@anirudhsudhir anirudhsudhir restored the feat-json-generator branch April 1, 2024 04:08
@anirudhsudhir anirudhsudhir linked an issue Apr 5, 2024 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON Generator
2 participants