-
Notifications
You must be signed in to change notification settings - Fork 21
handles to stretch the shape #15
base: main
Are you sure you want to change the base?
handles to stretch the shape #15
Conversation
Thanks for this. I think the PR might be missing some code parts, however. At the moment, it doesn't do anything. If I understand correctly, the code is for moving stretch handles that will resize the shape. However, there are currently no stretch handles, meaning that code will never get executed. Can you check, or describe what you intend to do? |
Woops... I forgot to change a line in the function getPoints. I will commit a change soon. The correct line should be My purpose in this pull request is to add many stretch handles to the boundary, so that we can adjust a local part of the boundary by dragging a handle. This feature is useful if we want to correct/refine a part of the boundary. I also plan to redraw freely a part of the boundary. After connecting the end points, the old part would disappear. Is that a good idea? |
Thanks for the update! Redrawing freely sounds like an interesting use case & would be a good addition I think. Just one thing: at the moment, its no longer possible to move the shape as a whole. There's an exception when I think with just a bit of refactoring, that's probably easy to address without additional code. Would you be ok looking into this? Editable freehand would be an excellent addition - thanks for the work so far! |
Thanks, Rainer. You are right. Now the freehand shape is not moveable as a whole. A regression. How to fix that? Without querySelector('.a9s-inner'), the function getPoints does not work. I will look into the "handles don't move along" problem. In the mean time, I will keep working on the editable freehand drawing tool. Hopefully I can get some preliminary results in a few days. |
No description provided.