Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#493 Added selection state re-evaluation on userSelectAction change #494

Conversation

oleksandr-danylchenko
Copy link
Contributor

@oleksandr-danylchenko oleksandr-danylchenko commented Dec 13, 2024

Issue

See - #493

A user can create an "impossible" state where the userSelectAction is SELECT or NONE, but both the selected is present and the editable is true.**

Changes Made

Added selection state re-evaluation call after updating the currentUserSelectAction. That way, the editing property on the selection will stay up-to-date. Also, the consumers subscribed to the selection state will receive the updated state properly.

@rsimon
Copy link
Member

rsimon commented Dec 19, 2024

Good catch - thanks!

@rsimon rsimon merged commit 637a263 into annotorious:main Dec 19, 2024
@oleksandr-danylchenko oleksandr-danylchenko deleted the #493-action-change-selection-state branch December 19, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants