Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/1206 - SDK: Adding events to shielded sync #1212

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

jurevans
Copy link
Collaborator

@jurevans jurevans commented Oct 25, 2024

Resolves #1206
todo

  • export progress types - scanned/fetched/applied
  • remove "// total is 0 so we do not get NaN"
  • fix circular dependency in balance/services.ts
  • export progress bar status
  • add event payload types
  • EventDispatcher scope type as enum?
  • check if options.bubbles(true); etc is needed

@jurevans jurevans force-pushed the feat/1206-shielded-sync-events branch 4 times, most recently from 2a72925 to c318d65 Compare October 31, 2024 16:45
@mateuszjasiuk mateuszjasiuk self-assigned this Nov 15, 2024
@mateuszjasiuk mateuszjasiuk force-pushed the feat/1206-shielded-sync-events branch 4 times, most recently from 0d240de to 945189a Compare November 19, 2024 12:51
@mateuszjasiuk mateuszjasiuk marked this pull request as ready for review November 19, 2024 14:00
@mateuszjasiuk mateuszjasiuk changed the title WIP: feat/1206 - SDK: Adding events to shielded sync feat/1206 - SDK: Adding events to shielded sync Nov 19, 2024
Copy link
Contributor

@euharrison euharrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting this error when the sync starts

Screenshot 2024-11-19 at 19 51 26

And this one when it finishes

Screenshot 2024-11-19 at 19 53 13

Do you know what it could be?

I already run the yarn wasm:build:dev

@mateuszjasiuk
Copy link
Collaborator

I'm not sure, maybe clear the old context from the IDB?

Copy link
Contributor

@euharrison euharrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🚀

I'm still getting this error, but it's working like a charm!

Screenshot 2024-11-21 at 12 00 34

...prev,
[name]: 100,
}));
});
Copy link
Contributor

@euharrison euharrison Nov 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll need to add the off here to avoid a memory leak, but we can do this later together with the UI update :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SDK: Shielded-Sync should broadcast events
3 participants