Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable shielding tx #1260

Merged
merged 5 commits into from
Nov 21, 2024
Merged

feat: enable shielding tx #1260

merged 5 commits into from
Nov 21, 2024

Conversation

euharrison
Copy link
Contributor

@euharrison euharrison commented Nov 15, 2024

Enable the Shielding feature on http://localhost:5173/masp/shield

Please note that this is the second PR on the Shield journey, we still have a lot to do but smaller PRs are easier to review and merge

Some missing features that will be addressed in the future:

  • Unshield transfer with the zsknam...
  • Visual tweaks on the transfer progress state
  • Automatically shielded sync after the transfer, so the person don't need to refresh the page
  • Improve the transaction history to have a better data and visualfor shield transfers

closes #1238

Screen.Recording.2024-11-15.at.00.40.08.mov

@brentstone
Copy link

@euharrison does this also close #1269?

Copy link
Collaborator

@mateuszjasiuk mateuszjasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and looks good! :)

@euharrison
Copy link
Contributor Author

@brentstone , no, this PR will fix the form on https://interface.namada-dryrun.tududes.com/masp/shield

@euharrison euharrison merged commit 4c30598 into main Nov 21, 2024
10 checks passed
@euharrison euharrison deleted the feat/sign-shielding-tx branch November 21, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement the Internal Shield Transaction
3 participants