-
Notifications
You must be signed in to change notification settings - Fork 993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dump tx output for reveal_pk transactions when requested #4061
Conversation
there are a few ways to implement this so wanted to add color to my choices. happy to change -
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4061 +/- ##
==========================================
+ Coverage 73.91% 74.31% +0.40%
==========================================
Files 341 341
Lines 106496 107401 +905
==========================================
+ Hits 78718 79817 +1099
+ Misses 27778 27584 -194 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
crates/apps_lib/src/client/tx.rs
Outdated
if let Address::Implicit(ImplicitAddress(pkh)) = | ||
&(&args.public_key).into() | ||
{ | ||
let public_key = &namada |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't need to look-up the PK as we already have it in args.public_key
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in aaf7679
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx for the fix!
aaf7679
to
3420f00
Compare
Describe your changes
It is currently not possible to generate the
reveal_pk
transaction offline. This PR will dump the transaction when requested.Checklist before merging
breaking::
labelsnamada-docs
reponamada-indexer
ornamada-masp-indexer
, a corresponding PR is opened in that repo