This repository has been archived by the owner on Aug 31, 2024. It is now read-only.
Add HomeManager module #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default script are using sed, awk, cat, ps, pgrep, dmenu and notify-send which leads to failure if they are not present in the environment. This commits pins them to a specific nixpkgs version. Also, numenc is using cat, which also fails if eg. run from a systemd unit.
Because we need to specify version and vendorSha256 in buildGo119Module anyway, we don't really profit from using the flake inputs. Having to remember to change values in different files after a `nix flake update` is error prone.
Lykos153
force-pushed
the
feature/modules
branch
from
0c97b62
to
ace02a5
Compare
|
I think I'd like to add a bit more information to the README |
|
I made some small changes: Lykos153#1 I can also submit them to this project, but do not think it is maintained anymore. This comment is mainly for visibility, in case someone needs it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I
(And Fixup scripts #4 is included as well, to avoid mistakes during rebasing. So Fixup scripts #4 should either be merged first or closed.)
If you prefer, I'll split it into smaller PRs.