Add optional ext
keyword argument to set_cover()
#11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
set_cover()
would rely on the Python standard moduleimghdr
to determine the type of the specified cover image file. Unfortunately,imghdr
does not support SVG, soset_cover()
could not handle that type (which is permitted by the EPUB spec).Detecting SVG files programmatically is nontrivial. Instead, simply provide an option for the client to specify the file type with the new keyword argument.
This introduces a minimal addition to the public API of the module.
I have two reservations about this PR:
ext
. It's not exactly an extension. But it's not exactly a MIME type, either. I'm not sure what a better name would be.