-
Notifications
You must be signed in to change notification settings - Fork 343
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
s3_bucket - fix typing for Python <3.9 (#2288)
Fixes: #2287 SUMMARY Support for type hinting generics in standard collections was first added in Python 3.9. We're currently not running the sanity tests against Python 3.7 (including the compilation/import tests), so we missed this. (We currently test 3.9-3.12) Using quay.io/ansible/default-test-container:8.12.0 locally to run the tests against 3.7 I see: (2.7 and 3.6 are skipped because this collection doesn't support them) Running sanity test "import" on Python 2.7 Running sanity test "import" on Python 3.6 Running sanity test "import" on Python 3.7 ERROR: Found 1 import issue(s) on python 3.7 which need to be resolved: ERROR: plugins/modules/s3_bucket.py:571:0: traceback: TypeError: 'type' object is not subscriptable See documentation for help: https://docs.ansible.com/ansible-core/2.16/dev_guide/testing/sanity/import.html Running sanity test "import" on Python 3.8 ERROR: Found 1 import issue(s) on python 3.8 which need to be resolved: ERROR: plugins/modules/s3_bucket.py:571:0: traceback: TypeError: 'type' object is not subscriptable See documentation for help: https://docs.ansible.com/ansible-core/2.16/dev_guide/testing/sanity/import.html Running sanity test "import" on Python 3.9 Running sanity test "import" on Python 3.10 Running sanity test "import" on Python 3.11 Running sanity test "import" on Python 3.12 ISSUE TYPE Bugfix Pull Request COMPONENT NAME s3_bucket ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis
- Loading branch information
Showing
2 changed files
with
14 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
--- | ||
bugfixes: | ||
- s3_bucket - Fixes Python 3.7 compilation issue due to addition of typing information (https://github.com/ansible-collections/amazon.aws/issues/2287). |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters