s3_object: fix value typo from last to latest (#1847)

s3_object: fix value typo from last to latest SUMMARY Fixes #1777 Fixing value for overwrite to not produce deprecation warning on setting overwirte=latest. ISSUE TYPE Bugfix Pull Request COMPONENT NAME s3_object ADDITIONAL INFORMATION Reviewed-by: Helen Bailey <[email protected]> Reviewed-by: Jill R (cherry picked from commit 8435113)
ansible-collections · Nov 14, 2023 · a90a9fe · a90a9fe
1 parent d3dc8da
commit a90a9fe
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/changelogs/fragments/1847-s3_object-fix-false-deprecation-warning.yml b/changelogs/fragments/1847-s3_object-fix-false-deprecation-warning.yml
@@ -0,0 +1,3 @@
+---
+bugfixes:
+  - s3_object - Fix typo that caused false deprecation warning when setting `overwrite=latest` (https://github.com/ansible-collections/amazon.aws/pull/1847).
diff --git a/plugins/modules/s3_object.py b/plugins/modules/s3_object.py
@@ -1481,11 +1481,11 @@ def main():
         if "amazonaws.com" not in endpoint_url:
             module.fail_json(msg="dualstack only applies to AWS S3")
 
-    if module.params.get("overwrite") not in ("always", "never", "different", "last"):
+    if module.params.get("overwrite") not in ("always", "never", "different", "latest"):
         module.deprecate(
             (
                 "Support for passing values of 'overwrite' other than 'always', 'never', "
-                "'different' or 'last', has been deprecated."
+                "'different' or 'latest', has been deprecated."
             ),
             date="2024-12-01",
             collection_name="amazon.aws",