ec2_instance - Fix issue with launch template #2323
Conversation
…launch template without a defined default subnet
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
tests/integration/targets/ec2_instance_launch_template/tasks/main.yml
Outdated
Show resolved
Hide resolved
| elif not network and not network_interfaces_ids: | ||
| # They did not specify any network interface configuration | ||
| # build network interface using subnet_id and security group(s) defined on the module | ||
| elif not network and not network_interfaces_ids and not module.params.get("launch_template"): |
There was a problem hiding this comment.
I won't block the PR on this, but as far as I can tell, this is the only line that actually needs to be changed to fix the bug. I'd really prefer that any refactoring should happen in a separate PR.
There was a problem hiding this comment.
Handling the refactoring in a separate PR makes sense. I'll leave the decision to @abikouo , as he is the original author of this PR.
There was a problem hiding this comment.
@gravesm the PR does not include any code refactoring, all changes are aimed at fixing the reported issue
…ain.yml Co-authored-by: Mike Graves <[email protected]>
softwarefactory-project-zuul
bot
merged commit 5e17269
into
ansible-collections:main
Backport to stable-9: 💚 backport PR created✅ Backport PR branch: Backported as #2410 🤖 @patchback |
SUMMARY Closes #2321 ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_instance Reviewed-by: Alina Buzachis Reviewed-by: Mike Graves <[email protected]> Reviewed-by: GomathiselviS <[email protected]> Reviewed-by: Bikouo Aubin (cherry picked from commit 5e17269)
SUMMARY Closes ansible-collections#2321 ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_instance Reviewed-by: Alina Buzachis Reviewed-by: Mike Graves <[email protected]> Reviewed-by: GomathiselviS <[email protected]> Reviewed-by: Bikouo Aubin
SUMMARY Closes ansible-collections#2321 ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_instance Reviewed-by: Alina Buzachis Reviewed-by: Mike Graves <[email protected]> Reviewed-by: GomathiselviS <[email protected]> Reviewed-by: Bikouo Aubin
SUMMARY
Closes #2321
ISSUE TYPE
COMPONENT NAME
ec2_instance