Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cloudformation: Fix bug when updating stack's termination_protection with create_changeset set #2391

Merged
merged 5 commits into from
Dec 19, 2024
Merged

cloudformation: Fix bug when updating stack's termination_protection with create_changeset set #2391

merged 5 commits into from
Dec 19, 2024

Conversation

mandar242
Copy link
Contributor

@mandar242 mandar242 commented Nov 15, 2024 •
edited
Loading

SUMMARY

Fixes #2149
Fix bug where termination protection is not updated when create_changeset=true is used for stack updates

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

cloudformation

ADDITIONAL INFORMATION

@mandar242 mandar242 mentioned this pull request Nov 15, 2024
Closed
1 task
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/2e5df5c2dddd43669e7bddc7aff0dae1

✔️ ansible-galaxy-importer SUCCESS in 5m 34s
✔️ build-ansible-collection SUCCESS in 10m 11s
✔️ ansible-test-splitter SUCCESS in 3m 53s
✔️ integration-amazon.aws-1 SUCCESS in 15m 26s
Skipped 43 jobs

hakbailey
hakbailey reviewed Nov 18, 2024
View reviewed changes
Copy link
Contributor

@hakbailey hakbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add an integration test for this case?

abikouo
abikouo approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@abikouo abikouo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!
Just missing integration tests

@mandar242 mandar242 force-pushed the cloudformation-bug-fix branch from d9a6377 to 72b3833 Compare December 11, 2024 18:04
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/345cee546d4442ad838629646d1596fe

✔️ ansible-galaxy-importer SUCCESS in 6m 53s
✔️ build-ansible-collection SUCCESS in 10m 19s
✔️ ansible-test-splitter SUCCESS in 4m 10s
✔️ integration-amazon.aws-1 SUCCESS in 14m 19s
Skipped 43 jobs

@mandar242 mandar242 requested a review from hakbailey December 11, 2024 19:40
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/002364d33ab24f4bb24bf8eefd46b27c

✔️ ansible-galaxy-importer SUCCESS in 5m 38s
✔️ build-ansible-collection SUCCESS in 10m 10s
✔️ ansible-test-splitter SUCCESS in 3m 55s
❌ integration-amazon.aws-1 FAILURE in 6m 27s
Skipped 43 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/c002f9072a9145e291a05c7276b88a25

✔️ ansible-galaxy-importer SUCCESS in 5m 05s
✔️ build-ansible-collection SUCCESS in 10m 50s
✔️ ansible-test-splitter SUCCESS in 3m 55s
✔️ integration-amazon.aws-1 SUCCESS in 16m 58s
Skipped 43 jobs

@mandar242 mandar242 added the mergeit Merge the PR (SoftwareFactory) label Dec 19, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/86ab562d146b49f69bb2791e91b336bc

✔️ ansible-galaxy-importer SUCCESS in 5m 11s
✔️ build-ansible-collection SUCCESS in 10m 17s
✔️ ansible-test-splitter SUCCESS in 4m 11s
✔️ integration-amazon.aws-1 SUCCESS in 15m 18s
Skipped 43 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 86b9182 into ansible-collections:main Dec 19, 2024
45 checks passed
@patchback Patchback
Copy link

patchback bot commented Dec 19, 2024 •
edited
Loading

Backport to stable-9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-9/86b9182767c67b32627c3aeafc727ac582bebf21/pr-2391

Backported as #2428

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Dec 19, 2024
@mandar242 @patchback
cloudformation: Fix bug when updating stack's termination_protection …
f9085ee 
…with create_changeset set (#2391)

SUMMARY

Fixes #2149
Fix bug where termination protection is not updated when create_changeset=true is used for stack updates

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

cloudformation
ADDITIONAL INFORMATION

Reviewed-by: Helen Bailey <[email protected]>
Reviewed-by: Bikouo Aubin
Reviewed-by: GomathiselviS <[email protected]>
(cherry picked from commit 86b9182)
@patchback patchback bot mentioned this pull request Dec 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abikouo abikouo abikouo approved these changes

@GomathiselviS GomathiselviS GomathiselviS approved these changes

@hakbailey hakbailey Awaiting requested review from hakbailey

@alinabuzachis alinabuzachis Awaiting requested review from alinabuzachis

Assignees
No one assigned
Labels
backport-9 mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Termination Protection is not Enabled for Existing Stacks when Create Change Set is Enabled
5 participants
@mandar242 @hakbailey @GomathiselviS @abikouo @alinabuzachis