Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ec2_security_group - Fix diff mode issue #2404

Merged
merged 1 commit into from
Dec 13, 2024
Merged

ec2_security_group - Fix diff mode issue #2404

merged 1 commit into from
Dec 13, 2024

Conversation

abikouo
Copy link
Contributor

@abikouo abikouo commented Dec 2, 2024

SUMMARY

Closes #2373

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ec2_security_group

@abikouo
ec2_security_group - fix diff mode issue when creating security group…
308c98a 
… containing at least one rule with a managed prefix list
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/66e349ed451046209803e19d6d53d48e

✔️ ansible-galaxy-importer SUCCESS in 3m 35s
✔️ build-ansible-collection SUCCESS in 10m 38s
✔️ ansible-test-splitter SUCCESS in 3m 57s
✔️ integration-amazon.aws-1 SUCCESS in 12m 45s
Skipped 43 jobs

@alinabuzachis alinabuzachis added backport-9 backport-8 PR should be backported to the stable-8 branch labels Dec 11, 2024
@abikouo abikouo added the mergeit Merge the PR (SoftwareFactory) label Dec 13, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/e423de7ae5dc4af7a5344405fc7ce16f

✔️ ansible-galaxy-importer SUCCESS in 5m 17s
✔️ build-ansible-collection SUCCESS in 10m 28s
✔️ ansible-test-splitter SUCCESS in 3m 49s
✔️ integration-amazon.aws-1 SUCCESS in 12m 19s
Skipped 43 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 6712ec6 into ansible-collections:main Dec 13, 2024
47 checks passed
@patchback Patchback
Copy link

patchback bot commented Dec 13, 2024 •
edited
Loading

Backport to stable-8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-8/6712ec69d01c179dbbc8a0a08e0605f8cd5670ec/pr-2404

Backported as #2423

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Dec 13, 2024
@abikouo @patchback
ec2_security_group - fix diff mode issue when creating security group…
00ab92d 
… containing at least one rule with a managed prefix list (#2404)

SUMMARY
Closes #2373
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

ec2_security_group

Reviewed-by: Alina Buzachis
(cherry picked from commit 6712ec6)
@patchback patchback bot mentioned this pull request Dec 13, 2024
Merged
@patchback Patchback
Copy link

patchback bot commented Dec 13, 2024 •
edited
Loading

Backport to stable-9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-9/6712ec69d01c179dbbc8a0a08e0605f8cd5670ec/pr-2404

Backported as #2424

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Dec 13, 2024
@abikouo @patchback
ec2_security_group - fix diff mode issue when creating security group…
e96b951 
… containing at least one rule with a managed prefix list (#2404)

SUMMARY
Closes #2373
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

ec2_security_group

Reviewed-by: Alina Buzachis
(cherry picked from commit 6712ec6)
@patchback patchback bot mentioned this pull request Dec 13, 2024
Merged
@github-actions GitHub Actions
Copy link

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

softwarefactory-project-zuul bot pushed a commit that referenced this pull request Dec 13, 2024
@patchback
ec2_security_group - fix diff mode issue when creating security group…
90dff60 
… containing at least one rule with a managed prefix list (#2404) (#2424)

This is a backport of PR #2404 as merged into main (6712ec6).
SUMMARY
Closes #2373
ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

ec2_security_group

Reviewed-by: Bikouo Aubin
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Dec 13, 2024
@patchback
ec2_security_group - fix diff mode issue when creating security group…
b1b6678 
… containing at least one rule with a managed prefix list (#2404) (#2423)

This is a backport of PR #2404 as merged into main (6712ec6).
SUMMARY
Closes #2373
ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

ec2_security_group

Reviewed-by: Bikouo Aubin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alinabuzachis alinabuzachis alinabuzachis approved these changes

Assignees
No one assigned
Labels
backport-8 PR should be backported to the stable-8 branch backport-9 mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ec2_security_group - Module failure when mixing rules with 'group_name' and 'ip_prefix' with --diff
2 participants
@abikouo @alinabuzachis