fix port-security-bug in nxos #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #906 +/- ##
=======================================
Coverage 84.91% 84.91%
=======================================
Files 221 221
Lines 18606 18606
=======================================
Hits 15799 15799
Misses 2807 2807 |
rohitthakur2590
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fix port-security feature name mapping in nxos_feature module. The module was using "eth_port_sec" as the internal feature name, but on NXOS systems the actual feature name is "eth-port-sec". This caused the module to fail with "Invalid Feature Name" error when trying to enable/disable port-security.
Fixes #896
ISSUE TYPE
COMPONENT NAME
nxos_feature